fix(fault-lib): correct MAX_PATH_LENGTH, macro, and dependency issues

bburda42dot · bburda42dot · commit 8ad4b82baa30 · 2026-02-17T14:22:36.000+01:00
- Fix MAX_PATH_LENGTH constant (256 → 128) to match LongString capacity
- Fix fault_descriptor! macro: optional fields now produce None when
  omitted, name/summary properly convert to ShortString/LongString
- Replace thread::park() with park_timeout(5s) to prevent infinite hang
  if IPC worker panics before unpark
- Remove unused async-trait dependency
- Move clap and env_logger to dev-dependencies (only used in examples)
- Remove env_logger and async-trait from Bazel rust_library deps
- Hide test_utils from public API with #[doc(hidden)]
- Fix typo: publsh_success → publish_success
- Remove unnecessary #[allow(dead_code)] and commented-out code
- Update copyright headers from 2025 to 2026 (all files created in 2026)
diff --git a/BUILD b/BUILD
@@ -10,6 +10,7 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 # *******************************************************************************
+
 load("@score_cr_checker//:cr_checker.bzl", "copyright_checker")
 load("@score_dash_license_checker//:dash.bzl", "dash_license_checker")
 load("@score_docs_as_code//:docs.bzl", "docs")
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/docs/examples/hvac_component_design_reference.rs b/docs/examples/hvac_component_design_reference.rs
@@ -1,5 +1,5 @@
 /*
-* Copyright (c) 2025 The Contributors to Eclipse OpenSOVD (see CONTRIBUTORS)
+* Copyright (c) 2026 The Contributors to Eclipse OpenSOVD (see CONTRIBUTORS)
 *
 * See the NOTICE file(s) distributed with this work for additional
 * information regarding copyright ownership.
diff --git a/src/common/BUILD b/src/common/BUILD
@@ -11,7 +11,7 @@
 # SPDX-License-Identifier: Apache-2.0
 # *******************************************************************************
 
-load("@rules_rust//rust:defs.bzl", "rust_binary", "rust_library", "rust_test")
+load("@rules_rust//rust:defs.bzl", "rust_library", "rust_test")
 
 filegroup(
     name = "common_srcs",
diff --git a/src/common/src/catalog.rs b/src/common/src/catalog.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/common/src/config.rs b/src/common/src/config.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/common/src/debounce.rs b/src/common/src/debounce.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/common/src/enabling_condition.rs b/src/common/src/enabling_condition.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/common/src/fault.rs b/src/common/src/fault.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/common/src/ids.rs b/src/common/src/ids.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/common/src/ipc_service_name.rs b/src/common/src/ipc_service_name.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/common/src/ipc_service_type.rs b/src/common/src/ipc_service_type.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/common/src/lib.rs b/src/common/src/lib.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/common/src/sink_error.rs b/src/common/src/sink_error.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/common/src/types.rs b/src/common/src/types.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/dfm_lib/examples/dfm.rs b/src/dfm_lib/examples/dfm.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/dfm_lib/examples/sovd_fault_manager.rs b/src/dfm_lib/examples/sovd_fault_manager.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/dfm_lib/src/aging_manager.rs b/src/dfm_lib/src/aging_manager.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/dfm_lib/src/dfm_test_utils.rs b/src/dfm_lib/src/dfm_test_utils.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/dfm_lib/src/diagnostic_fault_manager.rs b/src/dfm_lib/src/diagnostic_fault_manager.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/dfm_lib/src/enabling_condition_registry.rs b/src/dfm_lib/src/enabling_condition_registry.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/dfm_lib/src/fault_catalog_registry.rs b/src/dfm_lib/src/fault_catalog_registry.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/dfm_lib/src/fault_lib_communicator.rs b/src/dfm_lib/src/fault_lib_communicator.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/dfm_lib/src/fault_record_processor.rs b/src/dfm_lib/src/fault_record_processor.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/dfm_lib/src/lib.rs b/src/dfm_lib/src/lib.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/dfm_lib/src/operation_cycle.rs b/src/dfm_lib/src/operation_cycle.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/dfm_lib/src/sovd_fault_manager.rs b/src/dfm_lib/src/sovd_fault_manager.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/dfm_lib/src/sovd_fault_storage.rs b/src/dfm_lib/src/sovd_fault_storage.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/fault_lib/BUILD b/src/fault_lib/BUILD
@@ -23,13 +23,9 @@ rust_library(
     srcs = [":fault_lib_srcs"],
     crate_name = "fault_lib",
     edition = "2024",
-    proc_macro_deps = [
-        "@score_fault_lib_crates//:async-trait",
-    ],
     visibility = ["//visibility:public"],
     deps = [
         "//src/common",
-        "@score_fault_lib_crates//:env_logger",
         "@score_fault_lib_crates//:iceoryx2",
         "@score_fault_lib_crates//:iceoryx2-bb-container",
         "@score_fault_lib_crates//:log",
diff --git a/src/fault_lib/Cargo.toml b/src/fault_lib/Cargo.toml
@@ -6,17 +6,16 @@ readme.workspace = true
 
 [dependencies]
 common = { path = "../common" }
-async-trait = "0.1.89"
-env_logger.workspace = true
 iceoryx2.workspace = true
 iceoryx2-bb-container.workspace = true
 log = { workspace = true, features = ["std"] }
 serde_json.workspace = true
 serde = { workspace = true, features = ["derive"] }
 sha2.workspace = true
 thiserror.workspace = true
-clap = { version = "4.5.53", features = ["derive"] }
 
 [dev-dependencies]
+clap = { version = "4.5.53", features = ["derive"] }
+env_logger.workspace = true
 mockall.workspace = true
 serial_test.workspace = true
diff --git a/src/fault_lib/examples/catalog_and_reporter.rs b/src/fault_lib/examples/catalog_and_reporter.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/fault_lib/examples/tst_app.rs b/src/fault_lib/examples/tst_app.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/fault_lib/src/api.rs b/src/fault_lib/src/api.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/fault_lib/src/catalog.rs b/src/fault_lib/src/catalog.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/fault_lib/src/enabling_condition.rs b/src/fault_lib/src/enabling_condition.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/fault_lib/src/fault_manager_sink.rs b/src/fault_lib/src/fault_manager_sink.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
@@ -106,7 +106,9 @@ impl FaultManagerSink {
             .expect("Cannot spawn Fault Mgr Client sink thread");
 
         tx.send(WorkerMsg::Start(thread::current())).expect("Couldn't start the worker thread");
-        thread::park();
+        // Use park_timeout to avoid hanging forever if the worker thread
+        // panics before calling unpark. 5 seconds is generous for thread init.
+        thread::park_timeout(Duration::from_secs(5));
 
         let node = NodeBuilder::new()
             .create::<ServiceType>()
@@ -154,7 +156,7 @@ impl FaultManagerSink {
 }
 
 /// Maximum path length for fault entity paths (matches LongString capacity).
-const MAX_PATH_LENGTH: usize = 256;
+const MAX_PATH_LENGTH: usize = 128;
 
 /// Validate entity path format.
 ///
diff --git a/src/fault_lib/src/ipc_worker.rs b/src/fault_lib/src/ipc_worker.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/fault_lib/src/lib.rs b/src/fault_lib/src/lib.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
@@ -33,4 +33,5 @@ pub use sink::{FaultSinkApi, LogHook, NoOpLogHook};
 
 pub mod utils;
 
+#[doc(hidden)]
 pub mod test_utils;
diff --git a/src/fault_lib/src/reporter.rs b/src/fault_lib/src/reporter.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
@@ -167,7 +167,7 @@ mod tests {
     }
 
     #[test]
-    fn publsh_success() {
+    fn publish_success() {
         let mut mock_sink = MockFaultSinkApi::new();
         mock_sink.expect_publish().once().returning(|path, record| {
             assert_eq!(path, "test/path");
@@ -244,7 +244,6 @@ mod design_tests {
         }
     }
 
-    #[allow(dead_code)]
     fn make_reporter_with_descriptor(sink: Arc<dyn FaultSinkApi>, descriptor: FaultDescriptor) -> Reporter {
         let debouncer = descriptor.reporter_side_debounce.map(|mode| mode.into());
         Reporter {
diff --git a/src/fault_lib/src/sink.rs b/src/fault_lib/src/sink.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/fault_lib/src/test_utils.rs b/src/fault_lib/src/test_utils.rs
@@ -1,4 +1,4 @@
-// Copyright (c) 2025 Contributors to the Eclipse Foundation
+// Copyright (c) 2026 Contributors to the Eclipse Foundation
 //
 // See the NOTICE file(s) distributed with this work for additional
 // information regarding copyright ownership.
diff --git a/src/fault_lib/src/utils.rs b/src/fault_lib/src/utils.rs
diff --git a/src/xtask/src/main.rs b/src/xtask/src/main.rs
diff --git a/tests/integration/src/helpers.rs b/tests/integration/src/helpers.rs
diff --git a/tests/integration/src/lib.rs b/tests/integration/src/lib.rs
diff --git a/tests/integration/src/test_lifecycle_transitions.rs b/tests/integration/src/test_lifecycle_transitions.rs
diff --git a/tests/integration/src/test_multi_catalog.rs b/tests/integration/src/test_multi_catalog.rs
diff --git a/tests/integration/src/test_persistent_storage.rs b/tests/integration/src/test_persistent_storage.rs
diff --git a/tests/integration/src/test_report_and_query.rs b/tests/integration/src/test_report_and_query.rs

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@`
`10`	`10`	`#`
`11`	`11`	`# SPDX-License-Identifier: Apache-2.0`
`12`	`12`	`# *******************************************************************************`
	`13`	`+`
`13`	`14`	`load("@score_cr_checker//:cr_checker.bzl", "copyright_checker")`
`14`	`15`	`load("@score_dash_license_checker//:dash.bzl", "dash_license_checker")`
`15`	`16`	`load("@score_docs_as_code//:docs.bzl", "docs")`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`/*`
`2`		`-* Copyright (c) 2025 The Contributors to Eclipse OpenSOVD (see CONTRIBUTORS)`
	`2`	`+* Copyright (c) 2026 The Contributors to Eclipse OpenSOVD (see CONTRIBUTORS)`
`3`	`3`	`*`
`4`	`4`	`* See the NOTICE file(s) distributed with this work for additional`
`5`	`5`	`* information regarding copyright ownership.`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-// Copyright (c) 2025 Contributors to the Eclipse Foundation`
	`1`	`+// Copyright (c) 2026 Contributors to the Eclipse Foundation`
`2`	`2`	`//`
`3`	`3`	`// See the NOTICE file(s) distributed with this work for additional`
`4`	`4`	`// information regarding copyright ownership.`