Support for minimize-raise behavior

[ffs-akl]

I’m using sfwbar, and I have the following action configured:

action[Drag] = if windowinfo("focused") minimize() else focus();

With labwc, this allows me to click a window icon in the taskbar and get the following behavior: if the corresponding window is not focused, it will be focused; if it is already focused, it will be minimized.

I find this particularly useful when using a stacking compositor/window manager. There is a video demonstrating this behavior here:

labwc-mini-raise.mp4

However, with shojiwm, I can only focus an unfocused window. Clicking the icon of an already focused window does not minimize it.

Is this the expected behavior in shojiwm?

shijiwm-mini-raise.mp4

If so, is there any way to achieve the same behavior — that is, clicking an unfocused window's icon in the taskbar focuses it, while clicking the icon of the currently focused window minimizes it?

Thank you for your time, and I appreciate any guidance you can provide.

[bea4dev]

fixed in b79ec4d

With this fix, clicking a dock icon will minimize the window if it is already focused.
Please update both ShojiWM itself and window-manager.ts.

[ffs-akl]

Than you!
Based on my testing with two bars placed at the bottom of the screen (Sfwbar positioned on top of Noctalia Bar), the feature currently behaves inconsistently:

Current Behavior vs. Expected Behavior
Noctalia Bar: It successfully triggers minimize-raise even though it wasn't explicitly designed to support it. From the logs, it consistently sends an activate command, which seems to trigger the restore/raise in ShojiWM as a side effect.

Sfwbar: It fails to perform minimize-raise in ShojiWM, even though it is a standard-compliant bar that works flawlessly under labwc. Logs show that Sfwbar sends a explicit minimize / unminimize-related command sequence rather than just a raw activate.

Context & Links
Sfwbar issue reference: GitHub Issue #498

Noctalia discussion reference: GitHub Issue #3861

Feedback
The current implementation is actually perfect for my personal use case, as I primarily use Noctalia, and its ability to trigger this behavior—while perhaps unexpected—is a welcome surprise. However, I’m raising this feedback because I have a hunch that relying on this specific behavior may cause compatibility issues for other standard-compliant tools in the future. I wanted to bring this to your attention in case you’d like to ensure more robust protocol handling.

I have a video demonstrating the contrast between the two bars if you would find it helpful. Thank you for your continued work on ShojiWM!

noctalia-sfwbar-minimize-raise.mp4

[ffs-akl]

After testing SFWBar again, I found the following behavior:

Test	Result under shojiwm	Conclusion
action[LeftClick] = Focus()	Focus works correctly	Focus() works
action[LeftClick] = Minimize()	Minimize works correctly	Minimize() works
action[LeftClick] = if windowinfo("focused") Minimize() else Focus()	Always executes Focus()	windowinfo("focused") is always false
action[LeftClick] = if !windowinfo("focused") Minimize() else Focus()	Always executes Minimize()	Confirms windowinfo("focused") is always false

Based on these tests, shojiwm can correctly execute the commands sent by SFWBar. The problem is that windowinfo("focused") always returns false under shojiwm.

Under labwc, windowinfo("focused") returns the correct state, so the same SFWBar logic can correctly implement the minimize-raise behavior.

Therefore, the problem appears to be with the window state information between shojiwm and SFWBar: either shojiwm is not providing the correct focused-window information, or SFWBar's windowinfo() cannot correctly interpret the information provided by shojiwm.

[bea4dev]

fixed in 92e913a