Does not work with R version 4.2.2

[TarJae]

Thank you for this great package!
I have started this qeustion on stackoverflow https://stackoverflow.com/questions/74503566/crudtable-crashes-when-starting-from-rstudio-error-in-if-the-condition-has-len

It works if I start with R version 4.0.5.
Could you please solve this.

[thothal]

The guy who gave an answer on StackOverflow here.

The issue stems from these lines

crudtable/R/simpleFormUIFactory.R

Lines 28 to 36 in 8fd55e6

	if (a$type == 'factor') {
	selectInput(ns(name), name, choices = a$levels)
	} else if (a$type == 'numeric') {
	numericInput(ns(name), name, value = NA)
	} else if (a$type == 'logical') {
	checkboxInput(ns(name), name)
	} else {
	textInput(ns(name), name, value = NA)
	}

If a column in the data is a ordered factor, the corresponding type slot contains both its classes as we see in in the implementation of attributeType

crudtable/R/attributeType.R

Line 19 in 8fd55e6

res$type <- class(x)

This is the case for column Plant in the sample Co2 dataset_

class(CO2$Plant)
# [1] "ordered" "factor" 

Using if with a condition of length greater than 1 became an error in R 4.2.0. Thus, the example fails with these R versions.

A simple fix would be to replace == with %in% in the checks:

            if ('factor' %in% a$type) {
                selectInput(ns(name), name, choices = a$levels)
            } else if ('numeric' %in% a$type) {
                numericInput(ns(name), name, value = NA)
            } else if ('logical' %in% a$type) {
                checkboxInput(ns(name), name)
            } else {
                textInput(ns(name), name, value = NA)
            }

Because of this usually a better approach for testing for a specific class is inherits:

if ("factor" == class(ordered(1))) 1 ## will fail
## vs
if (inherits(ordered(1), "factor")) 1 ## will work

Having said this, this is most likely not a solution here, as it would require a major redesign of class dao.