From 2fec22f69dcd664b55201bc79a4eabf968e51e9e Mon Sep 17 00:00:00 2001 From: Joshua Borton Date: Fri, 13 Jan 2017 10:50:25 -0500 Subject: [PATCH 1/4] Add support for array of files fixes #141 --- addon/uploaders/base.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/addon/uploaders/base.js b/addon/uploaders/base.js index b2185e5..9e51b39 100644 --- a/addon/uploaders/base.js +++ b/addon/uploaders/base.js @@ -86,7 +86,8 @@ export default Ember.Object.extend(Ember.Evented, { } } - if (files.constructor === FileList) { + // if is a array of files ... + if (files.constructor === FileList || files.constructor === Array) { const paramKey = `${this.toNamespacedParam(this.paramName)}[]`; for (let i = 0; i < files.length; i++) { From 29be8fbf070dccbfe71fddce162dc8f8f5de10ee Mon Sep 17 00:00:00 2001 From: Joshua Borton Date: Fri, 13 Jan 2017 10:52:18 -0500 Subject: [PATCH 2/4] Bump to 1.2.3 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 201c078..50717c8 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "title": "Ember Uploader", "name": "ember-uploader", - "version": "1.2.2", + "version": "1.2.3", "description": "Ember.js addon to facilitate uploading", "homepage": "https://github.com/benefitcloud/ember-uploader", "license": "MIT", From f1b2f98ab159595fb993077b68637229e9017cf8 Mon Sep 17 00:00:00 2001 From: Charles Demers Date: Mon, 6 Mar 2017 13:17:14 -0500 Subject: [PATCH 3/4] Remove documentation about passing an array to the S3 uploader MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Passing an array of files doesn’t work with the current implementation so it should not be documented as such. --- addon/uploaders/s3.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addon/uploaders/s3.js b/addon/uploaders/s3.js index 785d34f..c3d5f4e 100644 --- a/addon/uploaders/s3.js +++ b/addon/uploaders/s3.js @@ -33,7 +33,7 @@ export default Uploader.extend({ /** * Request signed upload policy and upload file(s) and any extra data * - * @param {object|array} files One file object or one array of files object + * @param {object} file A file object * @param {object} extra Extra data to be sent with the upload * @return {object} Returns a Ember.RSVP.Promise wrapping the signing * request object @@ -61,7 +61,7 @@ export default Uploader.extend({ /** * Request signed upload policy * - * @param {object|array} files One file object or one array of files object + * @param {object} file A file object * @param {object} extra Extra data to be sent with the upload * @return {object} Returns a Ember.RSVP.Promise wrapping the signing * request object From 1d02f4e611bf332363437c2cfb01b7df52c4204d Mon Sep 17 00:00:00 2001 From: Ben Kiefer Date: Mon, 13 Nov 2017 08:37:37 -0600 Subject: [PATCH 4/4] allow users to specify a custom capture value --- addon/components/file-field.js | 1 + tests/unit/file-field-test.js | 17 +++++++++++++++++ 2 files changed, 18 insertions(+) diff --git a/addon/components/file-field.js b/addon/components/file-field.js index 2dd76a3..a8f0714 100644 --- a/addon/components/file-field.js +++ b/addon/components/file-field.js @@ -9,6 +9,7 @@ export default Ember.Component.extend(Ember.Evented, { 'form', 'type', 'accept', + 'capture', 'autofocus', 'required', 'multiple' diff --git a/tests/unit/file-field-test.js b/tests/unit/file-field-test.js index e1acb4e..e6212f0 100644 --- a/tests/unit/file-field-test.js +++ b/tests/unit/file-field-test.js @@ -15,3 +15,20 @@ test('it triggers `filesDidChange` on change', () => { deepEqual(result, [ 'foo' ], 'it returns the files that changed'); }); + +test('attribute bindings are correct', () => { + const fileField = FileField.extend({}).create(); + + deepEqual(fileField.get('attributeBindings'), [ + 'ariaRole:role', + 'name', + 'disabled', + 'form', + 'type', + 'accept', + 'capture', + 'autofocus', + 'required', + 'multiple' + ]); +});