Linking with LLD fails due to undefined versioned symbols

[kraj]

Building using lld linker fails with following errors

| x86_64-yoesdk-linux-ld.lld: error: version script assignment of 'XCRYPT_2.0' to symbol 'crypt_gensalt_r' failed: symbol not defined
| x86_64-yoesdk-linux-ld.lld: error: version script assignment of 'XCRYPT_2.0' to symbol 'xcrypt' failed: symbol not defined
| x86_64-yoesdk-linux-ld.lld: error: version script assignment of 'XCRYPT_2.0' to symbol 'xcrypt_gensalt' failed: symbol not defined
| x86_64-yoesdk-linux-ld.lld: error: version script assignment of 'XCRYPT_2.0' to symbol 'xcrypt_gensalt_r' failed: symbol not defined
| x86_64-yoesdk-linux-ld.lld: error: version script assignment of 'XCRYPT_2.0' to symbol 'xcrypt_r' failed: symbol not defined
| x86_64-yoesdk-linux-clang: error: linker command failed with exit code 1 (use -v to see invocation)

since LLD has stricter defaults and strict symbol versioning enforcement.
LLD requires that all symbols
referenced in version scripts actually exist in the object files being
linked Same errors/behavior can be
seen with GNU linker as well if we add -Wl,--undefined-version to LDFLAGS
GNU linker chooses to be a bit lenient with defaults.

To reproduce it install clang/lld and use LDFLAGS="-fuse-ld=lld"

[satmandu]

The use of mold linker is also causing the same issues on 4.5.0:

 mold: warning: ./libcrypt.map: cannot assign version `GLIBC_2.2.5` to symbol `encrypt`: symbol not found
mold: warning: ./libcrypt.map: cannot assign version `GLIBC_2.2.5` to symbol `encrypt_r`: symbol not found
mold: warning: ./libcrypt.map: cannot assign version `GLIBC_2.2.5` to symbol `fcrypt`: symbol not found
mold: warning: ./libcrypt.map: cannot assign version `GLIBC_2.2.5` to symbol `setkey`: symbol not found
mold: warning: ./libcrypt.map: cannot assign version `GLIBC_2.2.5` to symbol `setkey_r`: symbol not found
mold: warning: ./libcrypt.map: cannot assign version `XCRYPT_2.0` to symbol `crypt_gensalt_r`: symbol not found
mold: warning: ./libcrypt.map: cannot assign version `XCRYPT_2.0` to symbol `xcrypt`: symbol not found
mold: warning: ./libcrypt.map: cannot assign version `XCRYPT_2.0` to symbol `xcrypt_gensalt`: symbol not found
mold: warning: ./libcrypt.map: cannot assign version `XCRYPT_2.0` to symbol `xcrypt_gensalt_r`: symbol not found
mold: warning: ./libcrypt.map: cannot assign version `XCRYPT_2.0` to symbol `xcrypt_r`: symbol not found

[satmandu]

I think this is a duplicate of #181

[besser82]

@kraj @satmandu Can you check if #215 will fix this and give me some feedback, please?

[satmandu]

@kraj @satmandu Can you check if #215 will fix this and give me some feedback, please?

Commented to mention how that did not fix the build using mold linker at #215 (comment)

[besser82]

@satmandu mold with LTO is early stages of development. I've tried to link after the changes from the PR using lld, and there are no errors emitted anymore.

[satmandu]

I'm seeing these errors now:

(Sorry, on Mobile...)

I can open an issue with @ru314 on the mold repo...