From 41ad827e009599cf62d1875b1bdfc880219427df Mon Sep 17 00:00:00 2001 From: Valerii Chkalov Date: Mon, 6 Dec 2021 13:44:19 +0200 Subject: [PATCH 1/9] stt --- .circleci/config.yml | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index d33057a4..fcaf3919 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -3,14 +3,22 @@ orbs: ci: bigcommerce/internal@volatile microapp: bigcommerce/internal-microapp@volatile +default_params: &default_params + context: Bintray Access + +##################################################### +# Workflows +##################################################### workflows: version: 2 - ci-checks: + full: jobs: - - microapp/lint - - microapp/test - - microapp/build - - ci/validate-commits + - microapp/lint: + <<: *default_params + - microapp/test: + <<: *default_params + - microapp/build: + <<: *default_params - microapp/upload-artifact: context: Artifact Bucket Access @@ -21,5 +29,4 @@ workflows: - ci/notify-success: requires: - - ci/validate-commits - microapp/upload-artifact From 54d29b3e67bbc6527e45ea4d656c1bfa7043a14f Mon Sep 17 00:00:00 2001 From: Valerii Chkalov Date: Mon, 13 Dec 2021 14:16:24 +0200 Subject: [PATCH 2/9] BCTHEME-796 updated dep links --- .gitignore | 4 ++++ package.json | 2 +- yarn.lock | 4 ++-- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.gitignore b/.gitignore index 8e219b37..bd19b37c 100644 --- a/.gitignore +++ b/.gitignore @@ -8,3 +8,7 @@ # IDE .vscode/ +.DS_Store + +# Logs +yarn-error.log diff --git a/package.json b/package.json index 8c89232e..282a62c4 100644 --- a/package.json +++ b/package.json @@ -48,7 +48,7 @@ "js-cookie": "^2.2.0", "lodash": "^4.17.5", "nanoid": "^1.0.2", - "ng-build": "github:bigcommerce-labs/ng-build#14.0.10", + "ng-build": "git+https://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@github.com/bigcommerce-labs/ng-build.git#14.0.10", "prop-types": "^15.6.1", "react-emotion": "^9.1.2", "styled-components": "^4.4.1" diff --git a/yarn.lock b/yarn.lock index 3e03b167..c4e30a3c 100644 --- a/yarn.lock +++ b/yarn.lock @@ -15617,9 +15617,9 @@ next-tick@^1.0.0, next-tick@~1.0.0: version "1.0.0" resolved "https://registry.yarnpkg.com/next-tick/-/next-tick-1.0.0.tgz#ca86d1fe8828169b0120208e3dc8424b9db8342c" -"ng-build@github:bigcommerce-labs/ng-build#14.0.10": +"ng-build@git+https://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@github.com/bigcommerce-labs/ng-build.git#14.0.10": version "14.0.10" - resolved "git+ssh://git@github.com/bigcommerce-labs/ng-build.git#53366df79cba5db81695969d8493180611c34a4e" + resolved "git+https://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@github.com/bigcommerce-labs/ng-build.git#53366df79cba5db81695969d8493180611c34a4e" dependencies: "@babel/core" "^7.10.2" "@babel/plugin-proposal-class-properties" "^7.10.1" From f5aca8dd96ffce0c32131fa39cc4a43daf1af40e Mon Sep 17 00:00:00 2001 From: Valerii Chkalov Date: Mon, 13 Dec 2021 14:20:40 +0200 Subject: [PATCH 3/9] BCTHEME-796 updated token --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 282a62c4..cf1b7cb5 100644 --- a/package.json +++ b/package.json @@ -48,7 +48,7 @@ "js-cookie": "^2.2.0", "lodash": "^4.17.5", "nanoid": "^1.0.2", - "ng-build": "git+https://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@github.com/bigcommerce-labs/ng-build.git#14.0.10", + "ng-build": "git+https://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@github.com/bigcommerce-labs/ng-build.git#14.0.10", "prop-types": "^15.6.1", "react-emotion": "^9.1.2", "styled-components": "^4.4.1" From 6b94ddfd26ebbbc33751230922c2c9bc788f471a Mon Sep 17 00:00:00 2001 From: Valerii Chkalov Date: Mon, 13 Dec 2021 14:27:08 +0200 Subject: [PATCH 4/9] BCTHEME-796 updated dep link --- package.json | 2 +- yarn.lock | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index cf1b7cb5..3c8e55f0 100644 --- a/package.json +++ b/package.json @@ -48,7 +48,7 @@ "js-cookie": "^2.2.0", "lodash": "^4.17.5", "nanoid": "^1.0.2", - "ng-build": "git+https://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@github.com/bigcommerce-labs/ng-build.git#14.0.10", + "ng-build": "git+ssh://git@github.com:bigcommerce-labs/ng-build.git#14.0.10", "prop-types": "^15.6.1", "react-emotion": "^9.1.2", "styled-components": "^4.4.1" diff --git a/yarn.lock b/yarn.lock index c4e30a3c..b0c353f4 100644 --- a/yarn.lock +++ b/yarn.lock @@ -15617,9 +15617,9 @@ next-tick@^1.0.0, next-tick@~1.0.0: version "1.0.0" resolved "https://registry.yarnpkg.com/next-tick/-/next-tick-1.0.0.tgz#ca86d1fe8828169b0120208e3dc8424b9db8342c" -"ng-build@git+https://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@github.com/bigcommerce-labs/ng-build.git#14.0.10": +"ng-build@git+ssh://git@github.com:bigcommerce-labs/ng-build.git#14.0.10": version "14.0.10" - resolved "git+https://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@github.com/bigcommerce-labs/ng-build.git#53366df79cba5db81695969d8493180611c34a4e" + resolved "git+ssh://git@github.com:bigcommerce-labs/ng-build.git#53366df79cba5db81695969d8493180611c34a4e" dependencies: "@babel/core" "^7.10.2" "@babel/plugin-proposal-class-properties" "^7.10.1" From 45a7d4819e20181f11123acbf2212a4fb438a2d9 Mon Sep 17 00:00:00 2001 From: Valerii Chkalov Date: Mon, 13 Dec 2021 15:15:14 +0200 Subject: [PATCH 5/9] testing with native config --- .circleci/config.yml | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index fcaf3919..d33057a4 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -3,22 +3,14 @@ orbs: ci: bigcommerce/internal@volatile microapp: bigcommerce/internal-microapp@volatile -default_params: &default_params - context: Bintray Access - -##################################################### -# Workflows -##################################################### workflows: version: 2 - full: + ci-checks: jobs: - - microapp/lint: - <<: *default_params - - microapp/test: - <<: *default_params - - microapp/build: - <<: *default_params + - microapp/lint + - microapp/test + - microapp/build + - ci/validate-commits - microapp/upload-artifact: context: Artifact Bucket Access @@ -29,4 +21,5 @@ workflows: - ci/notify-success: requires: + - ci/validate-commits - microapp/upload-artifact From f8c7120949f57d726a8a175d32503262a6a06b35 Mon Sep 17 00:00:00 2001 From: Valerii Chkalov Date: Mon, 13 Dec 2021 15:17:18 +0200 Subject: [PATCH 6/9] reverting config file --- .circleci/config.yml | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index d33057a4..fcaf3919 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -3,14 +3,22 @@ orbs: ci: bigcommerce/internal@volatile microapp: bigcommerce/internal-microapp@volatile +default_params: &default_params + context: Bintray Access + +##################################################### +# Workflows +##################################################### workflows: version: 2 - ci-checks: + full: jobs: - - microapp/lint - - microapp/test - - microapp/build - - ci/validate-commits + - microapp/lint: + <<: *default_params + - microapp/test: + <<: *default_params + - microapp/build: + <<: *default_params - microapp/upload-artifact: context: Artifact Bucket Access @@ -21,5 +29,4 @@ workflows: - ci/notify-success: requires: - - ci/validate-commits - microapp/upload-artifact From 3fc3b0fd87be69a7f3dc2120002e1b75f01eb35c Mon Sep 17 00:00:00 2001 From: Valerii Chkalov Date: Mon, 13 Dec 2021 15:25:04 +0200 Subject: [PATCH 7/9] testing with the new config --- .circleci/config.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index fcaf3919..3841e01e 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -23,8 +23,8 @@ workflows: - microapp/upload-artifact: context: Artifact Bucket Access requires: - - microapp/lint - - microapp/test + - lint + - test - microapp/build - ci/notify-success: From 2315df033fe5c7c699aa5d46b4847135c50de14a Mon Sep 17 00:00:00 2001 From: Valerii Chkalov Date: Mon, 13 Dec 2021 16:16:50 +0200 Subject: [PATCH 8/9] added aliases for the psc tasks --- .circleci/config.yml | 4 ++-- .eslintrc.js | 48 ++++++++++++++++++++++++++------------------ gulpfile.js | 2 ++ 3 files changed, 33 insertions(+), 21 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 3841e01e..fcaf3919 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -23,8 +23,8 @@ workflows: - microapp/upload-artifact: context: Artifact Bucket Access requires: - - lint - - test + - microapp/lint + - microapp/test - microapp/build - ci/notify-success: diff --git a/.eslintrc.js b/.eslintrc.js index 2891c4b0..d3adba51 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -10,28 +10,38 @@ module.exports = { '@typescript-eslint/no-floating-promises': 'error', '@typescript-eslint/explicit-function-return-type': 'off', '@typescript-eslint/ban-ts-ignore': 'off', - '@typescript-eslint/member-ordering': 'warn', - '@typescript-eslint/unbound-method': 'warn', - '@typescript-eslint/tslint/config': 'warn', + '@typescript-eslint/member-ordering': 'off', + '@typescript-eslint/unbound-method': 'off', + '@typescript-eslint/tslint/config': 'off', '@typescript-eslint/naming-convention': 'off', - '@typescript-eslint/ban-types': 'warn', + '@typescript-eslint/ban-types': 'off', '@typescript-eslint/camelcase': 'off', - '@typescript-eslint/ban-ts-comment': 'warn', - '@typescript-eslint/semi': 'warn', - 'import/namespace': 'warn', - 'import/no-extraneous-dependencies': 'warn', - 'import/order': 'warn', - 'import/default': 'warn', - 'import/extensions': 'warn', - 'import/no-unresolved': 'warn', - 'no-restricted-syntax': 'warn', - eqeqeq: 'warn', - 'no-useless-return': 'warn', - 'no-shadow': 'warn', + '@typescript-eslint/ban-ts-comment': 'off', + '@typescript-eslint/semi': 'off', + 'import/namespace': 'off', + 'import/no-extraneous-dependencies': 'off', + 'import/order': 'off', + 'import/default': 'off', + 'import/extensions': 'off', + 'import/no-unresolved': 'off', + 'no-restricted-syntax': 'off', + eqeqeq: 'off', + 'no-useless-return': 'off', + 'no-shadow': 'off', 'no-global-assign': 'off', - 'react/destructuring-assignment': 'warn', - 'react/jsx-no-bind': 'warn', - 'jsdoc/require-param-type': 'warn' + 'react/destructuring-assignment': 'off', + 'react/jsx-no-bind': 'off', + 'jsdoc/require-param-type': 'off', + 'func-names': 'off', + 'quote-props': 'off', + 'react/jsx-indent-props': 'off', + 'react/jsx-one-expression-per-line': 'off', + 'space-before-function-paren': 'off', + '@typescript-eslint/space-before-function-paren': 'off', + 'import/no-named-as-default': 'off', + 'import/no-named-as-default-member': 'off', + 'no-console': 'off', + '@typescript-eslint/no-non-null-assertion': 'off' }, settings: { react: { diff --git a/gulpfile.js b/gulpfile.js index 19d55d6e..b9dfad7c 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -17,3 +17,5 @@ const registry = new NgBuild(this, { }) gulp.registry(registry) +gulp.task('ci:lint', gulp.series(['lint'])) +gulp.task('ci:test', gulp.series(['test'])) From 23b5d23f54e0ca18b3ca73e6602ad48ebe49d5de Mon Sep 17 00:00:00 2001 From: Valerii Chkalov Date: Mon, 13 Dec 2021 16:41:48 +0200 Subject: [PATCH 9/9] removed notification --- .circleci/config.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index fcaf3919..e6b58f70 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -26,7 +26,3 @@ workflows: - microapp/lint - microapp/test - microapp/build - - - ci/notify-success: - requires: - - microapp/upload-artifact