Support for Bitcoin Bech32 SegWit addresses

[rex4539]

https://github.com/bitcoin/bips/blob/master/bip-0173.mediawiki

[mrosseel]

bisq depends on bitcoinj for its wallet/bitcoin transactions, and bitcoinj has no segwit/bech32 support as of today. If it's in bitcoinj, we will support it asap!

[sneurlax]

See bitcoinj/bitcoinj#1441 ... so we will get BIP49 (P2SH-P2WKPH, 3...) addresses before BIP173 (P2WKPH, bc1...) addresses

[ManfredKarrer]

I will close for now to keep GH organized with issues which are subject to be implemented in a reasonable time scope. I mark it as deferred.

[sneurlax]

See sipa/bech32#40 (comment)

@mrosseel: segwit support has been merged into bitcoinj master since june 2017: bitcoinj/bitcoinj#1334

[ManfredKarrer]

Thats not full segwit support. See BitcoinJ mailing list....

@mrosseel: thanks for clarifying; I wasn't aware that the current bitcoinj implementation is not complete, but in my understanding the existing code is enough to generate compatible segwit addresses that start with 3 as can be seen in the unit test at https://github.com/bitcoinj/bitcoinj/blob/segwit/core/src/test/java/org/bitcoinj/core/AddressTest.java#L178 (outdated segwit branch). I don't dominate the topic so I apologize in case if my assumptions are wrong... SamouraiWallet apparently relies on bitcoinj for segwit and they provide segwit support in their android wallet: https://github.com/Samourai-Wallet/samourai-wallet-android

[ManfredKarrer]

SamouraiWallet uses its own fork. I have not followed the details but I am pretty sure that BitcoinJ at the current state is not fully supporting SegWit.

SamouraiWallet uses 'compatible' i.e. non-bech32 segwit addresses which start with 3; this is also the format that ledger and trezor currently support. My understanding is that currently bitcoinj does handle this format, at least I was able to generate that type of addresses with the master or release branch. I assume by incomplete support you mean bech32 support, i.e. addresses that start with bc1 and which are still not widely adopted: https://en.bitcoin.it/wiki/Bech32_adoption

[cbeams]

I will close for now to keep GH organized with issues which are subject to be implemented in a reasonable time scope. I mark it as deferred.

@ManfredKarrer, I'm re-opening this issue. SegWit support is our number one requested feature, and this is the only issue we have to track it. Whether it can be implemented in a reasonable time frame is a matter of whether people step up to help implement it. Having this issue open can help potential contributors understand that we're actively looking for this help.