code refactor

Author: paulocoutinhox

.github/workflows/build.yml

@@ -53,7 +53,7 @@ jobs:
       - name: Build
         run: |
           rm -rf build
-          cmake -B build . -G Ninja -DCMAKE_BUILD_TYPE=Debug -DENABLE_TESTS=ON -DENABLE_ASAN=ON -DBUILD_EXECUTABLE=OFF
+          cmake -B build . -G Ninja -DCMAKE_BUILD_TYPE=Debug -DENABLE_TESTS=ON -DENABLE_ASAN=OFF -DBUILD_EXECUTABLE=OFF
           cmake --build build
           cd build && ctest --output-on-failure --verbose
 

include/bitchat/services/noise_service.h

@@ -24,10 +24,7 @@ class NoiseService
 {
 public:
     NoiseService();
-    ~NoiseService();
-
-    // Cleanup method
-    void cleanup();
+    ~NoiseService() = default;
 
     // Session management
     std::shared_ptr<NoiseSession> createSession(const std::string &peerID, NoiseRole role);

src/bitchat/services/noise_service.cpp

@@ -2,8 +2,6 @@
 #include "bitchat/core/constants.h"
 #include "bitchat/helpers/noise_helper.h"
 #include "bitchat/noise/noise_session_default.h"
-#include <openssl/err.h>
-#include <openssl/evp.h>
 #include <openssl/rand.h>
 #include <spdlog/spdlog.h>
 
@@ -18,30 +16,6 @@ NoiseService::NoiseService()
     }
 }
 
-NoiseService::~NoiseService()
-{
-    cleanup();
-}
-
-void NoiseService::cleanup()
-{
-    std::lock_guard<std::mutex> lock(sessionsMutex);
-
-    // Clear all sessions
-    sessions.clear();
-
-    // Clear OpenSSL
-    CRYPTO_set_locking_callback(nullptr);
-    CRYPTO_set_id_callback(nullptr);
-
-    ERR_remove_state(0);
-
-    ERR_free_strings();
-    EVP_cleanup();
-
-    CRYPTO_cleanup_all_ex_data();
-}
-
 std::shared_ptr<NoiseSession> NoiseService::createSession(const std::string &peerID, NoiseRole role)
 {
     std::lock_guard<std::mutex> lock(sessionsMutex);