From db8eabe85777b252449aa58bf4c7be6df7a2d00a Mon Sep 17 00:00:00 2001 From: Katherine Bertelsen Date: Wed, 17 Jun 2026 14:56:13 -0500 Subject: [PATCH] [PM-37318] chore: Standardize premium upgrade alert titles to "Premium subscription required" --- BitwardenResources/Localizations/en.lproj/Localizable.strings | 2 -- BitwardenShared/UI/Vault/Extensions/Alert+Vault.swift | 4 ++-- BitwardenShared/UI/Vault/Extensions/AlertVaultTests.swift | 2 +- .../UI/Vault/Vault/VaultList/VaultListProcessorTests.swift | 2 +- .../UI/Vault/VaultItem/VaultItemActionHelperTests.swift | 2 +- 5 files changed, 5 insertions(+), 7 deletions(-) diff --git a/BitwardenResources/Localizations/en.lproj/Localizable.strings b/BitwardenResources/Localizations/en.lproj/Localizable.strings index a70db53070..ef939ee1c1 100644 --- a/BitwardenResources/Localizations/en.lproj/Localizable.strings +++ b/BitwardenResources/Localizations/en.lproj/Localizable.strings @@ -1026,10 +1026,8 @@ "ArchiveEmptyDescriptionLong" = "Fill your archive with items you don’t want to see in search results and autofill suggestions but might need someday."; "ArchiveItem" = "Archive item"; "OnceArchivedThisItemWillBeExcludedDescriptionLong" = "Once archived, this item will be excluded from search results and autofill suggestions."; -"ArchiveUnavailable" = "Archive unavailable"; "ArchivingItemsIsAPremiumFeatureDescriptionLong" = "Archiving items is a Premium feature. Your current plan does not include access to this feature."; "AddingAttachmentsIsAPremiumFeatureDescriptionLong" = "Adding attachments is a Premium feature. Your current plan does not include access to this feature."; -"AttachmentsUnavailable" = "Attachments unavailable"; "UpgradeToPremium" = "Upgrade to premium"; "ThisItemIsArchived" = "This item is archived."; "YourPremiumSubscriptionEnded" = "Your Premium subscription ended"; diff --git a/BitwardenShared/UI/Vault/Extensions/Alert+Vault.swift b/BitwardenShared/UI/Vault/Extensions/Alert+Vault.swift index 732a79fa34..cc441c9202 100644 --- a/BitwardenShared/UI/Vault/Extensions/Alert+Vault.swift +++ b/BitwardenShared/UI/Vault/Extensions/Alert+Vault.swift @@ -20,7 +20,7 @@ extension Alert { await action() } let alert = Alert( - title: Localizations.archiveUnavailable, + title: Localizations.premiumSubscriptionRequired, message: Localizations.archivingItemsIsAPremiumFeatureDescriptionLong, alertActions: [ preferredAction, @@ -43,7 +43,7 @@ extension Alert { await action() } let alert = Alert( - title: Localizations.attachmentsUnavailable, + title: Localizations.premiumSubscriptionRequired, message: Localizations.addingAttachmentsIsAPremiumFeatureDescriptionLong, alertActions: [ preferredAction, diff --git a/BitwardenShared/UI/Vault/Extensions/AlertVaultTests.swift b/BitwardenShared/UI/Vault/Extensions/AlertVaultTests.swift index bffe9d1677..7f18ec9467 100644 --- a/BitwardenShared/UI/Vault/Extensions/AlertVaultTests.swift +++ b/BitwardenShared/UI/Vault/Extensions/AlertVaultTests.swift @@ -12,7 +12,7 @@ class AlertVaultTests: BitwardenTestCase { // swiftlint:disable:this type_body_l var called = false let subject = Alert.archiveUnavailable { called = true } - XCTAssertEqual(subject.title, Localizations.archiveUnavailable) + XCTAssertEqual(subject.title, Localizations.premiumSubscriptionRequired) XCTAssertEqual(subject.message, Localizations.archivingItemsIsAPremiumFeatureDescriptionLong) XCTAssertEqual(subject.alertActions.count, 2) XCTAssertEqual(subject.alertActions[0].title, Localizations.upgradeToPremium) diff --git a/BitwardenShared/UI/Vault/Vault/VaultList/VaultListProcessorTests.swift b/BitwardenShared/UI/Vault/Vault/VaultList/VaultListProcessorTests.swift index 0c20f65fa7..5c045bf0e1 100644 --- a/BitwardenShared/UI/Vault/Vault/VaultList/VaultListProcessorTests.swift +++ b/BitwardenShared/UI/Vault/Vault/VaultList/VaultListProcessorTests.swift @@ -2064,7 +2064,7 @@ class VaultListProcessorTests: BitwardenTestCase { // swiftlint:disable:this typ subject.receive(.itemPressed(item: archiveItem)) let alert = try XCTUnwrap(coordinator.alertShown.last) - XCTAssertEqual(alert.title, Localizations.archiveUnavailable) + XCTAssertEqual(alert.title, Localizations.premiumSubscriptionRequired) XCTAssertEqual(alert.message, Localizations.archivingItemsIsAPremiumFeatureDescriptionLong) try await alert.tapAction(title: Localizations.upgradeToPremium) diff --git a/BitwardenShared/UI/Vault/VaultItem/VaultItemActionHelperTests.swift b/BitwardenShared/UI/Vault/VaultItem/VaultItemActionHelperTests.swift index d13ecf9b00..93aba5972e 100644 --- a/BitwardenShared/UI/Vault/VaultItem/VaultItemActionHelperTests.swift +++ b/BitwardenShared/UI/Vault/VaultItem/VaultItemActionHelperTests.swift @@ -53,7 +53,7 @@ struct VaultItemActionHelperTests { ) let alert = try #require(coordinator.alertShown.last) - #expect(alert.title == Localizations.archiveUnavailable) + #expect(alert.title == Localizations.premiumSubscriptionRequired) #expect(alert.message == Localizations.archivingItemsIsAPremiumFeatureDescriptionLong) #expect(vaultRepository.archiveCipher.isEmpty) #expect(!completionCalled)