notes are not rendering italics and are spitting out errors

@queryluke luke, all the notes in erdman are spitting out errors and they're not rendering italics in <title level="m"> tags. i'm stumped. see, for example, the first note ('t' link) on page 674.

@queryluke also, every time i edit the erdman code and build with npm run-script watch, it results in a bad bundle.js. for one thing, the site doesn't load the TOC. i see this error in the console:

TypeError: Cannot read property 'sort' of undefined
at TocController.sortItems (bundle.js:19135)
at new TocController (...

so, something is amiss with the build script or with the code. it seems nathan might have checked in a bundle.js that doesn't correspond with the code, but i don't see how that would've happened.

[queryluke]

@BA001 Sorry for the delay. Just wanted to let you know that I'll look into this today or tomorrow.

[queryluke]

@BA001 I can't replicate the build issue. I tried both in my existing code but I also tried in a fresh clone of the erdman repo. Both are working fine.

I'd suggest blowing away your current erdman repo and recloning. The only file you want to save is server/config.py. Looks like there is also a "client/typings directory that is gitignored. Did you add that? If not, then just ignore it. Otherwise, you'll want to save that elsewhere as well.

Anyway, if I were doing this all in the terminal, assuming you're current dir is blake/ where we set up the virtualenv

cp erdman/server/config.py erdman_config.py.bak
rm -rf erdman
git clone https://github.com/blakearchive/erdman.git
mv erdman_config.py.bak erdman/server/config.py
cd erdman/client
npm install
npm run-script watch

Looking into the note issue now.

[queryluke]

@BA001 Ok, the issue here issue here is in the transform and the <title m> tag itself.

For background, when you run the deploy, all of the notes get transformed and shoved into /client/src/data.js

Here is what note #tn674.1 looks like after it's transformed:

<note id="tn674.1">
    <p xmlns:exist="http://exist.sourceforge.net/NS/exist">
        <quote>&#8220;How I pity&#8221;</quote> (perhaps a rejected design for  
        <title level="m">
            <span class="tei-hi-italic">The Gates of Paradise</span>
        </title>)is in an Album of Sketches in the British Museum.
    </p>
    <p xmlns:exist="http://exist.sourceforge.net/NS/exist">
        <quote>&#8220;Father&amp; Mother I return . . .&#8221;</quote> is the caption under an emblematicsketch of a
        bee-winged human, Rosenwald Collection, Library of Congress. On the back is a harvest emblem which is a variant
        of the design in
        <title level="m">
            <span class="tei-hi-italic">Milton</span>
        </title> 50; under that is an erased caption,not deciphered.  Both emblems are reproduced in the 1977
        <title level="m">
            <span class="tei-hi-italic">Notebook</span>
        </title> as Figs. 44 and 4.5. (For years the decipheredcaption, <quote>&#8220;Father &amp; Mother . . .&#8221;</quote>
        was mistakenlyreported as written on the back of or on a sketch of
        <title level="m">
            <span class="tei-hi-italic">Milton</span>
        </title> 50, but it has no evident connection with
        <title level="m"><span class="tei-hi-italic">Milton</span></title>.)
    </p>
</note>

The title tags are still there. That HTML get's bound to the dialog box in /client/src/components/note-overlay.js, line 14. The ng-bind-html directive is removing the <title> element (because <title> elements in HTML are only for document metadata, not for rendering). I'm not 100% sure why, but when the directive removes the title element it uses a plain string for everything else, which is why those spans aren't rendering as html.

So, you're going to need to add something in the xslt files that handles these title tags. Removing them or replacing them with a <span> element would also work. I'm not sure if they need additional styling. If so, you can replace them with <span class="title-m"> and then add that .title-m class and whatever styles you need to the css files.

[queryluke]

Data.js Problem

I can't remember if we went over this or not. I still can't get the transform scripts to run on my mac, so I assume you can't either. Which makes a bit of a conundrum when deploying.

1. Build production scripts (creates bundle.js)
2. Commit changes
3. Deploy
4. XML files get transformed, indexed in solr, and data.js gets updated
   See the problem...the UPDATED data.js never gets bundled into bundle.js.

To solve this, you need scp the data.js file from the server onto you local machine AFTER you deploy
and then run npm run-script build, commit, and redeploy (don't need to seed database this time)

It's a real pain, but that's the only way to do it. But if you can get scripts/transform.py to run on your local machine then you don't have to go through all this rigmarole.

Another option to the scripts not running on macs might be to look into virtual machines. If you can get the entire thing setup in a VM using Vagrant or something similar, it might get around the macOS issue. I will caution you that getting a setup like that might take some time. There is a lot to do with networking, installing packages, etc. Very sysadmin-y.

@queryluke luke, if you have time--i know you're leaving soon--could you go ahead and implement the solution you describe a comment up? this is the last major issue with erdman, and after it's resolved, i'm hoping to be able to just leave erdman be

[queryluke]

@BA001 Unfortunately, I don't think I will have time. I only did minor edits to the xslt files back in November and most of that was trial and error and copying from what was already there. I'll keep it in mind, but it's probably not likely.