From 9898671fc3855d629559671892428791a160263f Mon Sep 17 00:00:00 2001 From: Evgenii Malygin Date: Thu, 12 Mar 2026 14:24:20 -0400 Subject: [PATCH 1/3] CI: use native clang-format Remove dependency from a third-party clang-format image. Reduce formatter check time from ~2 minutes to a few seconds. Also print formatting errors in CI logs. Signed-off-by: Evgenii Malygin --- .github/workflows/build.yml | 26 +++++++++++--------------- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 1adff17c..0d507c23 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -15,7 +15,7 @@ concurrency: jobs: Docker: name: "Check whether docker setup, build, test work correctly." - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v3 - name: Docker Setup @@ -27,7 +27,7 @@ jobs: name: Doxygenize #Only run for push to main if: github.ref == 'refs/heads/main' - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 permissions: contents: write # Needed to push to gh-pages steps: @@ -43,26 +43,22 @@ jobs: ghpagesbranch: gh-pages # GitHub Pages directory path ghpagesdir: ./docs - + Formatting: name: Clang Format - runs-on: ubuntu-latest - strategy: - matrix: - path: - - 'src' - - 'examples' + runs-on: ubuntu-24.04 steps: - - uses: actions/checkout@v3 - - name: Run clang-format style check for C/C++/Protobuf programs. - uses: jidicula/clang-format-action@v4.11.0 + - uses: actions/checkout@v4 with: - clang-format-version: '20' - check-path: ${{ matrix.path }} + fetch-depth: 0 + - name: clang-format style check + run: | + git clang-format-18 --diff -q origin/main | tee format_diff.txt + if [ -s format_diff.txt ]; then exit 1; fi Linting: name: Shellcheck - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v3 - name: Run ShellCheck From 86039020addd14a4513fc3e5029c95bcfc6bfbb3 Mon Sep 17 00:00:00 2001 From: Evgenii Malygin Date: Thu, 12 Mar 2026 14:51:54 -0400 Subject: [PATCH 2/3] Update rmqamqp_channel.cpp Signed-off-by: Evgenii Malygin --- src/rmq/rmqamqp/rmqamqp_channel.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/rmq/rmqamqp/rmqamqp_channel.cpp b/src/rmq/rmqamqp/rmqamqp_channel.cpp index c23a540b..c7aa6247 100644 --- a/src/rmq/rmqamqp/rmqamqp_channel.cpp +++ b/src/rmq/rmqamqp/rmqamqp_channel.cpp @@ -106,10 +106,12 @@ class Channel::ChannelMethodProcessor { << d_channel.d_state << " state, but expected state is " << CHANNEL_OPEN_SENT; - d_channel.close(rmqamqpt::Constants::UNEXPECTED_FRAME, + d_channel.close( + rmqamqpt::Constants::UNEXPECTED_FRAME, "Unexpected frame", rmqamqpt::ChannelMethod::CLASS_ID, - rmqamqpt::ChannelOpenOk::METHOD_ID); + rmqamqpt::ChannelOpenOk::METHOD_ID + ); return KEEP; } From 50022b9dbd333c80b0b28cdd77bc022cc0c1af3a Mon Sep 17 00:00:00 2001 From: Evgenii Malygin Date: Thu, 12 Mar 2026 14:54:12 -0400 Subject: [PATCH 3/3] Update rmqamqp_channel.cpp Signed-off-by: Evgenii Malygin --- src/rmq/rmqamqp/rmqamqp_channel.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/rmq/rmqamqp/rmqamqp_channel.cpp b/src/rmq/rmqamqp/rmqamqp_channel.cpp index c7aa6247..c23a540b 100644 --- a/src/rmq/rmqamqp/rmqamqp_channel.cpp +++ b/src/rmq/rmqamqp/rmqamqp_channel.cpp @@ -106,12 +106,10 @@ class Channel::ChannelMethodProcessor { << d_channel.d_state << " state, but expected state is " << CHANNEL_OPEN_SENT; - d_channel.close( - rmqamqpt::Constants::UNEXPECTED_FRAME, + d_channel.close(rmqamqpt::Constants::UNEXPECTED_FRAME, "Unexpected frame", rmqamqpt::ChannelMethod::CLASS_ID, - rmqamqpt::ChannelOpenOk::METHOD_ID - ); + rmqamqpt::ChannelOpenOk::METHOD_ID); return KEEP; }