Change on the behavior of the folder location changing UI

[rafaellehmkuhl]

Eliot has given some suggestions on how to improve the UI for changing the default folder location:

I think it would be better if the interface was more like the other configs on the same page:

• Show the folder name in a text entry, which can be edited directly
  • We could allow typing/pasting a file path directly into it, with an extra button on the right to open a file selector
  • Alternatively clicking to type (entering focus) could automatically open a file selector
• Have a reset button (with a tooltip for its purpose) that is only enabled when the folder name is non-default
  • I'm not a fan of the long small clickable text in the current implementation, it's hard to read, hard to click on, and not obvious it even can be clicked on

I'm opening the topic here for us to better discuss a future change on it.

[rafaellehmkuhl]

One point that I want to bring around allowing the user to directly edit the folder path: it opens space for typos. That was the reason I didn't do it initially.

It can definitely be worked around thought (for example by warning the user that the folder does not exist), although it adds some important extra logic.

About the text buttons, I do agree. I have implemented them this way initially because it looked better, although I acknowledge that it can be less intuitive.

[ES-Alexander]

Yeah, if we allow typing then we need some kind of validation, although we probably want a fallback behaviour anyway in case the folder somehow gets deleted so the user doesn’t lose important videos or whatnot.

I did suggest we could make it visually a text entry but open up a file dialogue as soon as they click on it though, if that’s preferable? My primary idea is that I want to be able to click on the filepath to change it, and at the moment that’s not possible.

[ES-Alexander]

It also doesn’t have to be a text entry component, I just like the idea because it “feels” editable, and would stylistically fit with the other things in that settings pane, so users don’t need to learn a new thing to know where to click / what to do.

[rafaellehmkuhl]

Oooooo, ok, I didn't understand that. That makes sense indeed!

I would slightly change the tooltip to show "/path/to/folder - Click to change".

What about the reset button? Maybe just a "refresh" icon with a tooltip saying "Reset to default folder location" that only appears when the folder location is different?

Those could all be added in the PR already.

[ES-Alexander]

Changing the tooltip seems fine

Reset button can look and be placed similarly to the ones for the global address and the like, except I think all of those should actually be using mdi-restore - with mdi-refresh the arrow goes forwards, which has different implications.

[rafaellehmkuhl]

This is the final version of the PR before merging. I have done the suggestions here and also raplaced all mdi-refresh icons with mdi-restore for consistency.

@ES-Alexander let me know if you think the discussion should continue or if we can close it.

[ES-Alexander]

This looks fine to me, and got merged as part of the original PR :-)