feat(ie-shell): add navigation service, tab model, and bookmarks #7

- NavigationService trait (object-safe via async-trait) with
  InProcessNavigator wrapping ie-net::Client
- TabManager with tab lifecycle, cycling, back/forward history
- BookmarkStore with JSON persistence
- 27 new tests (7 navigation, 15 tab/history, 5 bookmark)

Author: thomasnemer

Cargo.lock

@@ -53,3 +53,6 @@ serde_json = "1"
 clap = { version = "4", features = ["derive"] }
 softbuffer = "0.4"
 bytes = "1"
+async-trait = "0.1"
+chrono = { version = "0.4", features = ["serde"] }
+tempfile = "3"

Cargo.toml

@@ -17,6 +17,17 @@ winit.workspace = true
 url.workspace = true
 clap.workspace = true
 softbuffer.workspace = true
+async-trait.workspace = true
+serde.workspace = true
+serde_json.workspace = true
+chrono.workspace = true
 ie-net.workspace = true
 ie-dom.workspace = true
 ie-sandbox.workspace = true
+
+[dev-dependencies]
+tempfile.workspace = true
+bytes.workspace = true
+http-body-util.workspace = true
+hyper.workspace = true
+hyper-util.workspace = true

crates/ie-shell/Cargo.toml

@@ -0,0 +1,113 @@
+use std::path::{Path, PathBuf};
+
+use anyhow::Result;
+use chrono::{DateTime, Utc};
+use serde::{Deserialize, Serialize};
+
+#[derive(Debug, Clone, Serialize, Deserialize)]
+pub struct Bookmark {
+    pub url: String,
+    pub title: String,
+    pub created: DateTime<Utc>,
+}
+
+pub struct BookmarkStore {
+    bookmarks: Vec<Bookmark>,
+    path: PathBuf,
+}
+
+impl BookmarkStore {
+    pub fn new(data_dir: &Path) -> Result<Self> {
+        let path = data_dir.join("bookmarks.json");
+        let bookmarks = if path.exists() {
+            let data = std::fs::read_to_string(&path)?;
+            serde_json::from_str(&data)?
+        } else {
+            Vec::new()
+        };
+        Ok(Self { bookmarks, path })
+    }
+
+    pub fn add(&mut self, url: &str, title: &str) -> Result<()> {
+        self.bookmarks.push(Bookmark {
+            url: url.to_string(),
+            title: title.to_string(),
+            created: Utc::now(),
+        });
+        self.save()
+    }
+
+    pub fn remove(&mut self, url: &str) -> Result<()> {
+        self.bookmarks.retain(|b| b.url != url);
+        self.save()
+    }
+
+    pub fn list(&self) -> &[Bookmark] {
+        &self.bookmarks
+    }
+
+    fn save(&self) -> Result<()> {
+        if let Some(parent) = self.path.parent() {
+            std::fs::create_dir_all(parent)?;
+        }
+        let json = serde_json::to_string_pretty(&self.bookmarks)?;
+        std::fs::write(&self.path, json)?;
+        Ok(())
+    }
+}
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn new_with_empty_dir() {
+        let dir = tempfile::tempdir().unwrap();
+        let store = BookmarkStore::new(dir.path()).unwrap();
+        assert!(store.list().is_empty());
+    }
+
+    #[test]
+    fn add_then_list() {
+        let dir = tempfile::tempdir().unwrap();
+        let mut store = BookmarkStore::new(dir.path()).unwrap();
+        store.add("https://example.com", "Example").unwrap();
+        assert_eq!(store.list().len(), 1);
+        assert_eq!(store.list()[0].url, "https://example.com");
+        assert_eq!(store.list()[0].title, "Example");
+    }
+
+    #[test]
+    fn remove_bookmark() {
+        let dir = tempfile::tempdir().unwrap();
+        let mut store = BookmarkStore::new(dir.path()).unwrap();
+        store.add("https://a.com", "A").unwrap();
+        store.add("https://b.com", "B").unwrap();
+        store.remove("https://a.com").unwrap();
+        assert_eq!(store.list().len(), 1);
+        assert_eq!(store.list()[0].url, "https://b.com");
+    }
+
+    #[test]
+    fn round_trip_persistence() {
+        let dir = tempfile::tempdir().unwrap();
+        {
+            let mut store = BookmarkStore::new(dir.path()).unwrap();
+            store.add("https://example.com", "Example").unwrap();
+            store.add("https://rust-lang.org", "Rust").unwrap();
+        }
+        let store = BookmarkStore::new(dir.path()).unwrap();
+        assert_eq!(store.list().len(), 2);
+        assert_eq!(store.list()[0].url, "https://example.com");
+        assert_eq!(store.list()[1].url, "https://rust-lang.org");
+    }
+
+    #[test]
+    fn add_duplicate_url_keeps_both() {
+        let dir = tempfile::tempdir().unwrap();
+        let mut store = BookmarkStore::new(dir.path()).unwrap();
+        store.add("https://example.com", "First").unwrap();
+        store.add("https://example.com", "Second").unwrap();
+        assert_eq!(store.list().len(), 2);
+    }
+}

crates/ie-shell/src/bookmarks.rs

@@ -12,8 +12,14 @@
 //! - No spell checking
 
 mod app;
+#[allow(dead_code)]
+mod bookmarks;
 mod cli;
 mod headless;
+#[allow(dead_code)]
+mod navigation;
+#[allow(dead_code)]
+mod tab;
 
 use anyhow::Result;
 use clap::Parser;