Skip to content

Redundant AWS events declaration #13

@jfsagasti

Description

@jfsagasti

As @NickSeagull pointed out, some cleanup may be possible. We are defining these events in the file-uploaded.ts file:

interface AWSEventS3 {
  s3SchemaVersion: string
  configurationId: string
  bucket: {
    name: string
    ownerIdentity: any
    arn: string
  }
  object: {
    key: string
    size: number
    eTag: string
    sequencer: string
  }
}

interface AWSEvent {
  eventVersion: string
  eventSource: string
  awsRegion: string
  eventTime: string
  eventName: string
  userIdentity: [Record<string, unknown>]
  requestParameters: [Record<string, unknown>]
  responseElements: [Record<string, unknown>]
  s3: AWSEventS3
}

But those events could already be in the AWS SDK, so this re-definition could be unnecessary.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions