ASA settings: link to Apple's OAuth setup docs#7
Merged
Conversation
Add an external link to Apple's 'Implementing OAuth for the Apple Search Ads API' page right under the Search Ads section description so users have an authoritative reference for generating their Client ID / Client Secret. Also tighten the surrounding copy: drop the '(free, no budget required), then Settings -> API -> Create New Client' aside since the linked Apple docs cover those steps in more detail and stay up to date as Apple's console UI evolves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In the Apple Search Ads API section of the Settings panel (
web/src/components/SettingsPanel.svelte):(free, no budget required), then Settings → API → Create New Clientaside since Apple's docs now cover the credential-generation steps in more detail.After:
Why
Following the OAuth wire-shape fix in #6, users who hit credential issues now have one authoritative source to consult. Apple's console UI for creating API clients changes occasionally — pointing at their docs keeps our help text from drifting stale, and the docs page itself covers the JWT generation steps we don't (and shouldn't) document inline.
Reviewer notes
<a href>in this file, so I introducedtarget="_blank" rel="noopener noreferrer"as the convention for any future external links here.text-amber-400 hover:underlinepalette (matches the "Replace" button in the same form) rather than introducing a blue link color — keeps the new element in-palette. between "guide" and the↗glyph so a line wrap can't orphan the arrow.Verification
npm run check— 0 errors, 0 warnings across 144 files