From 1029777d3f57125230d21d8043362d15cee53af2 Mon Sep 17 00:00:00 2001 From: Boris Batkin Date: Thu, 11 Jun 2026 01:09:03 -0700 Subject: [PATCH] binder: detect fixed-array args via isArray(), not dim.size() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit daslang PR GaijinEntertainment/daScript#3095 replaces TypeDecl's flattened dim/dimExpr vectors with a structural Type::tFixedArray — the dim member is gone. isArray() means "is a fixed-size array" in both worlds (dim.size() != 0 before, baseType == tFixedArray after), so this compiles and behaves identically against current daslang master and against the rework. Mergeable ahead of the daslang PR. Co-Authored-By: Claude Fable 5 --- src/cb_dasIMPLOT.h | 2 +- src/dasIMPLOT.main.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cb_dasIMPLOT.h b/src/cb_dasIMPLOT.h index 1bc40ec..910e4b5 100644 --- a/src/cb_dasIMPLOT.h +++ b/src/cb_dasIMPLOT.h @@ -32,7 +32,7 @@ struct implotTempFn { } bool anyString = false; for ( auto &arg : fn->arguments ) { - if ( arg->type->constant && arg->type->ref && arg->type->dim.size() == 0 ) { + if ( arg->type->constant && arg->type->ref && !arg->type->isArray() ) { if ( arg->type->baseType == Type::tFloat2 || arg->type->baseType == Type::tFloat4 ) { arg->type->ref = false; } diff --git a/src/dasIMPLOT.main.cpp b/src/dasIMPLOT.main.cpp index 875cfea..7570d63 100644 --- a/src/dasIMPLOT.main.cpp +++ b/src/dasIMPLOT.main.cpp @@ -314,7 +314,7 @@ void Module_dasIMPLOT::initMain () { // mirrors dasImguiNodeEditor's initMain fixup. for ( auto & pfn : this->functions.each() ) { for ( auto & arg : pfn->arguments ) { - if ( arg->type->constant && arg->type->ref && arg->type->dim.size()==0 ) { + if ( arg->type->constant && arg->type->ref && !arg->type->isArray() ) { if ( arg->type->baseType==Type::tFloat2 || arg->type->baseType==Type::tFloat4 ) { arg->type->ref = false; }