Skip to content

Commit b261e5d

Browse files
authored
Merge pull request #232 from kjoon418/validate-question/#231
[chore/#231] 답변 대기중인 문의만 수정할 수 있도록 검증 로직 추가
2 parents 5e5d966 + c89bd68 commit b261e5d

1 file changed

Lines changed: 9 additions & 10 deletions

File tree

src/main/java/goodspace/backend/qna/service/QuestionService.java

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
11
package goodspace.backend.qna.service;
22

3-
import goodspace.backend.qna.domain.Answer;
4-
import goodspace.backend.qna.dto.*;
5-
import goodspace.backend.qna.repository.QuestionFileRepository;
6-
import goodspace.backend.qna.repository.QuestionRepository;
3+
import goodspace.backend.global.security.TokenProvider;
74
import goodspace.backend.qna.domain.Question;
85
import goodspace.backend.qna.domain.QuestionFile;
96
import goodspace.backend.qna.domain.QuestionStatus;
7+
import goodspace.backend.qna.dto.*;
8+
import goodspace.backend.qna.repository.QuestionRepository;
109
import goodspace.backend.user.repository.UserRepository;
11-
import goodspace.backend.global.security.TokenProvider;
12-
import goodspace.backend.user.service.UserService;
1310
import lombok.RequiredArgsConstructor;
1411
import org.springframework.http.HttpHeaders;
1512
import org.springframework.http.MediaType;
@@ -31,11 +28,9 @@
3128
public class QuestionService {
3229
private final QuestionRepository questionRepository;
3330
private final UserRepository userRepository;
34-
private final QuestionFileRepository questionFileRepository;
35-
private final UserService userService;
3631

3732
@Transactional
38-
public String createQuestion(Principal principal, QuestionRequestDto dto, List<MultipartFile> files) throws IOException {
33+
public String createQuestion(Principal principal, QuestionRequestDto dto, List<MultipartFile> files) {
3934
Question question = Question.builder()
4035
.title(dto.getTitle())
4136
.content(dto.getContent())
@@ -70,10 +65,14 @@ public String createQuestion(Principal principal, QuestionRequestDto dto, List<M
7065
}
7166

7267
@Transactional
73-
public String modifyQuestion(Long id, QuestionRequestDto dto, List<MultipartFile> files) throws IOException {
68+
public String modifyQuestion(Long id, QuestionRequestDto dto, List<MultipartFile> files) {
7469
Question question = questionRepository.findById(id)
7570
.orElseThrow(() -> new IllegalArgumentException("수정하려는 질문을 데이터베이스에서 찾지 못하였습니다."));
7671

72+
if (question.getQuestionStatus() != QuestionStatus.WAITING) {
73+
throw new IllegalStateException("답변 완료된 질문은 수정할 수 없습니다.");
74+
}
75+
7776
question.modifyQuestion(dto.getTitle(), dto.getContent(), dto.getType());
7877

7978
question.clearQuestionFiles();

0 commit comments

Comments
 (0)