Error messages in console when editing file that is not versioned yet

[dichlofos]

1. Start ST (v2 in my case) from console
2. Create new file (denote by X) inside some hg/git repo
3. Try to edit it and save it

You'll see lots of messages about file X is not under version control: https://gist.github.com/dichlofos/5865560 is the sample

I think we should not try to diff files that are not versioned yet (or just squash these error messages).

I presumably know how to fix this problem for SVN and hg. As for git, its a bit trickier, but "git status" invocation should help here. Any other suggestions how to fix this?

[dichlofos]

Also I suggest to show a question marks in gutter on these files, indicating they are not versioned and you should say add to track them.

[schlamar]

I can't reproduce this with ST3 and hg. However, I'm seeing sometimes this error, it might be related:

Traceback (most recent call last):
  File "C:\Users\schlaich\Sublime Text 3\sublime_plugin.py", line 526, in run_
    return self.run()
  File "C:\Users\schlaich\Sublime Text 3\Data\Packages\VCS Gutter\vcs_gutter.py", line 34, in run
    inserted, modified, deleted = ViewCollection.diff(self.view)
  File "C:\Users\schlaich\Sublime Text 3\Data\Packages\VCS Gutter\view_collection.py", line 63, in diff
    return ViewCollection.views[key].diff()
KeyError: 'file_not_in_vcs.txt'

This happened for a file which was not inside any repository.

@dichlofos your last suggestion is already reported: #15

[dichlofos]

Yeah, @schlamar, traceback is even worse that my case (probably we see different Windows/Linux behavior!). Okay, I will see if this can be fixed too, on the nearest weekend :)

As for #15, that issue is slightly different, because it concerns ignored files, that should never been tracked. My suggestion concerns not added files.

[dichlofos]

Created #17 -- this should resolve first part of problems.

@schlamar, I reviewed the code, but I have no idea now that dict can be empty at run() except the case when gutter handler is None. Where your file_'not_in_vcs.txt' file was located? Inside valid VCS repo or outside?

[schlamar]

Where your file_'not_in_vcs.txt' file was located? Inside valid VCS repo or outside?

This happens only for files outside of repositiories. Sadly, it is not really reproducible.

[bradsokol]

@dichlofos I cannot reproduce the problem using your steps. I'm using OS X with ST2 and ST3. What OS and ST versions are you using?

@schlamar I've seen that error as well and can't figure out the cause. The next update will have a bit of code to catch and handle so that the console isn't full of noise.

[dichlofos]

ST2, Linux (e.g. Fedora 16). Sublime is started from terminal.

[dichlofos]

Fix #18 also helps with this one, so we can close this.

[bradsokol]

Great! Thanks for letting me know.