change versioning logic

Author: AbhiPrasad

.agents/skills/sdk-integrations/SKILL.md

@@ -109,21 +109,16 @@ Prefer feature detection first and version checks second.
 Use:
 
 - `detect_module_version(...)`
-- `version_in_range(...)`
-- `version_matches_spec(...)`
-
-Do not add `packaging` just for integration routing.
+- `version_satisfies(...)`
+- `make_specifier(...)`
 
 ## `auto_instrument()`
 
 Update `py/src/braintrust/auto.py` only if the integration should be auto-patched.
 
-Match the existing option shape:
-
-- use plain `bool` for simple on/off integrations that do not use the integrations API
-- use `InstrumentOption` for integrations API providers that support `IntegrationPatchConfig`
+Use `InstrumentOption` (i.e. `bool | IntegrationPatchConfig`) for all integrations, including those that do not yet use the integrations API. This keeps the signature uniform and avoids a breaking change when the integration is later migrated.
 
-For integrations API providers, use `_normalize_instrument_option()` and `_instrument_integration(...)` instead of adding a custom `_instrument_*` function:
+Use `_normalize_instrument_option()` and `_instrument_integration(...)` instead of adding a custom `_instrument_*` function:
 
 ```python
 enabled, config = _normalize_instrument_option("provider", provider)
@@ -180,6 +175,6 @@ cd py && make lint
 - Forgetting async or streaming coverage.
 - Adding patcher selection without tests for enabled and disabled cases.
 - Re-recording cassettes when behavior did not intentionally change.
-- Using `_normalize_bool_option()` for an integrations API provider.
+- Using `_normalize_bool_option()` instead of `_normalize_instrument_option()` — all integrations should accept `InstrumentOption`.
 - Adding a custom `_instrument_*` helper where `_instrument_integration()` already fits.
 - Forgetting `target_module` for deep or optional submodule patch targets.

py/src/braintrust/integrations/adk/__init__.py

@@ -18,7 +18,6 @@
 
 __all__ = [
     "ADKIntegration",
-    "_create_thread_wrapper",
     "setup_adk",
     "setup_braintrust",
     "wrap_agent",

py/src/braintrust/integrations/adk/integration.py

@@ -21,6 +21,7 @@ class ADKIntegration(BaseIntegration):
 
     name = "adk"
     import_names = ("google.adk",)
+    min_version = "1.14.1"
     patchers = (
         ThreadBridgePatcher,
         AgentRunAsyncPatcher,

py/src/braintrust/integrations/test_versioning.py

@@ -26,8 +26,9 @@ def test_version_satisfies_none_handling():
     assert version_satisfies("1.0", None)
     assert version_satisfies(None, None)
 
-    # No version with a spec means incompatible.
-    assert not version_satisfies(None, ">=1.0")
+    # No version with a spec — optimistically allow so patching still proceeds
+    # when version detection fails.
+    assert version_satisfies(None, ">=1.0")
 
 
 def test_version_satisfies_invalid_version():

py/src/braintrust/integrations/versioning.py

@@ -43,11 +43,17 @@ def make_specifier(*, min_version: str | None = None, max_version: str | None =
 
 
 def version_satisfies(version: str | None, spec: str | SpecifierSet | None) -> bool:
-    """Return True if *version* satisfies the PEP 440 *spec*."""
+    """Return True if *version* satisfies the PEP 440 *spec*.
+
+    When *version* is ``None`` (i.e. we could not detect the installed
+    version), we optimistically return ``True`` so that patching still
+    proceeds.  A failed detection should not silently disable
+    instrumentation.
+    """
     if spec is None:
         return True
     if version is None:
-        return False
+        return True
     try:
         ss = spec if isinstance(spec, SpecifierSet) else SpecifierSet(spec, prereleases=True)
         return Version(version) in ss