Skip to content

fix: Use data-* attributes for line number options #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brotkrueml merged 2 commits into from
Oct 17, 2025
Merged

fix: Use data-* attributes for line number options #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b6b2b9
fix: Use data-* attributes for line number options
sebkln Oct 17, 2025
5fc40d3
fix: Adjust unit tests for line number options
sebkln Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Classes/EventListener/HighlightLines.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ public function __invoke(EnrichCodeSnippetEvent $event): void
}

if ($event->options->highlightLines !== '') {
$event->preAttributesCollector->setAttribute('line', $event->options->highlightLines);
$event->preAttributesCollector->setAttribute('data-line', $event->options->highlightLines);

if ($event->options->startWithLineNumber > 1) {
$event->preAttributesCollector->setAttribute('line-offset', (string) ($event->options->startWithLineNumber - 1));
$event->preAttributesCollector->setAttribute('data-line-offset', (string) ($event->options->startWithLineNumber - 1));
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion Classes/EventListener/LineNumbers.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public function __invoke(EnrichCodeSnippetEvent $event): void
$event->scriptsCollector->addPath(Extension::PRISM_BASE_PATH . 'plugins/line-numbers/prism-line-numbers.min.js');

if ($event->options->startWithLineNumber > 1) {
$event->preAttributesCollector->setAttribute('start', (string) $event->options->startWithLineNumber);
$event->preAttributesCollector->setAttribute('data-start', (string) $event->options->startWithLineNumber);
}
}
}
6 changes: 3 additions & 3 deletions Tests/Unit/EventListener/HighlightLinesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public function highlightLinesIsSet(): void
self::assertSame('EXT:codehighlight/Resources/Public/Prism/plugins/line-highlight/prism-line-highlight.css', $event->stylesCollector->getPaths()[0]);
self::assertCount(1, $event->scriptsCollector->getPaths());
self::assertSame('EXT:codehighlight/Resources/Public/Prism/plugins/line-highlight/prism-line-highlight.min.js', $event->scriptsCollector->getPaths()[0]);
self::assertSame('line="3-5"', $event->preAttributesCollector->__toString());
self::assertSame('data-line="3-5"', $event->preAttributesCollector->__toString());
self::assertSame('', $event->preClassesCollector->__toString());
self::assertSame('', $event->codeAttributesCollector->__toString());
self::assertSame('', $event->codeClassesCollector->__toString());
Expand All @@ -86,7 +86,7 @@ public function highlightLinesIsSetAndStartWithLineNumberIsGreater1(): void

self::assertCount(1, $event->stylesCollector->getPaths());
self::assertCount(1, $event->scriptsCollector->getPaths());
self::assertSame('line="3-5" line-offset="1"', $event->preAttributesCollector->__toString());
self::assertSame('data-line="3-5" data-line-offset="1"', $event->preAttributesCollector->__toString());
self::assertSame('', $event->preClassesCollector->__toString());
self::assertSame('', $event->codeAttributesCollector->__toString());
self::assertSame('', $event->codeClassesCollector->__toString());
Expand All @@ -109,7 +109,7 @@ public function highlightLinesIsSetAndStartWithLineNumberIs1(): void

self::assertCount(1, $event->stylesCollector->getPaths());
self::assertCount(1, $event->scriptsCollector->getPaths());
self::assertSame('line="3-5"', $event->preAttributesCollector->__toString());
self::assertSame('data-line="3-5"', $event->preAttributesCollector->__toString());
self::assertSame('', $event->preClassesCollector->__toString());
self::assertSame('', $event->codeAttributesCollector->__toString());
self::assertSame('', $event->codeClassesCollector->__toString());
Expand Down
2 changes: 1 addition & 1 deletion Tests/Unit/EventListener/LineNumbersTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public function optionShowLineNumberIsActivatedAndStartWithLineNumberGreater1():

self::assertCount(1, $event->stylesCollector->getPaths());
self::assertCount(1, $event->scriptsCollector->getPaths());
self::assertSame('start="2"', $event->preAttributesCollector->__toString());
self::assertSame('data-start="2"', $event->preAttributesCollector->__toString());
self::assertSame('line-numbers', $event->preClassesCollector->__toString());
self::assertSame('', $event->codeAttributesCollector->__toString());
self::assertSame('', $event->codeClassesCollector->__toString());
Expand Down