From 79ba609d2054dd3d05fa3e869342632530d4e43f Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Thu, 15 Dec 2022 08:50:39 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- mlopt/optimizer.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/mlopt/optimizer.py b/mlopt/optimizer.py index ae90fb8..c10ef51 100644 --- a/mlopt/optimizer.py +++ b/mlopt/optimizer.py @@ -603,7 +603,26 @@ def from_file(cls, file_name): # Extract file to temporary directory and read it with tempfile.TemporaryDirectory() as tmpdir: with tarfile.open(file_name) as tar: - tar.extractall(path=tmpdir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=tmpdir) # Load optimizer optimizer_file_name = os.path.join(tmpdir, "optimizer.pkl")