From 349be597844e07d5b70ec45b0f470fbd1c625762 Mon Sep 17 00:00:00 2001 From: Shelly Lire Date: Mon, 3 Oct 2022 00:58:37 +0800 Subject: [PATCH] Enable computeChecksums instead of providing ContentMD5 https://github.com/aws/aws-sdk-js/issues/774#issuecomment-155837412 --- src/lib/s3-helper.js | 1 - src/steps.js | 1 + test/steps.spec.js | 6 +++++- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/lib/s3-helper.js b/src/lib/s3-helper.js index 24d65f5..a3a3736 100644 --- a/src/lib/s3-helper.js +++ b/src/lib/s3-helper.js @@ -131,7 +131,6 @@ class S3Helper { ACL: 'public-read', Key: fileName, Body: shouldBeZipped ? gzipStream(fStream) : fStream, - ContentMD5: Buffer.from(toUpload.hashes[fileName], 'hex').toString('base64'), }; if (contentType) { diff --git a/src/steps.js b/src/steps.js index af2a3b2..3f6cbd2 100644 --- a/src/steps.js +++ b/src/steps.js @@ -162,6 +162,7 @@ module.exports.detectFileChanges = (localHashes, remoteHashes) => { module.exports.configureAwsSdk = params => { logger.info('▹ Configuring AWS SDK'); const awsOptions = { + computeChecksums: true, sslEnabled: true, region: params.region, }; diff --git a/test/steps.spec.js b/test/steps.spec.js index 6307480..2cad350 100644 --- a/test/steps.spec.js +++ b/test/steps.spec.js @@ -325,6 +325,7 @@ describe('Steps', () => { region: 'awsRegion', }; const expectedOptions = Object.assign({ + computeChecksums: true, sslEnabled: true, }, params); const configuredAws = steps.configureAwsSdk(params); @@ -344,7 +345,10 @@ describe('Steps', () => { test('sets region and profile for aws sdk module', () => { const params = { region: 'awsRegion', profile: 'profile' }; - const expectedOptions = Object.assign({ sslEnabled: true }, params); + const expectedOptions = Object.assign({ + computeChecksums: true, + sslEnabled: true, + }, params); delete expectedOptions.profile; const sharedCredentialsMock = { cred: 'val' };