Allow setting starting output

[anssih]

It would be useful to be able to set the starting output (simple_pid.pid.PID(starting_output=x)) via a number entity.

I use this for A/C control and would prefer it not to blow cold air for a bit when the controller starts :)

Also, thank you for this component, it is just what I wanted (a UI configurable PID controller that just does PID control, letting me "wire" the inputs and outputs as I choose).

[bvweerd]

Thanks for the request.

Should it only go to the starting_output during startup of HA, or also after a 'reset' by re-enabling auto mode?

[anssih]

Hmm, good question. I see that the latter is controlled by the last_output= parameter of PID.set_auto_mode().

So there are actually two cases:

1. PID creation, starting_output parameter of PID(), defaults to 0.
2. PID auto-mode re-enable, last_output parameter of set_auto_mode(), defaults to 0.

I would like to have something non-zero in both of those, i.e. either the last output (for case 1 this would be from the previous HA run), or a custom value from a number entity.

I think for my use case a number entity that is used for both 1 and 2 would work best, but I'm also entirely fine with a solution where one or both of those cases use the last output instead.

[bvweerd]

So, to complete the list of possible use cases, we would have (at least):

Startup

1. Start at 0
2. Start at previous value on startup
3. Start at input-number on startup
4. ...

and:

Re-enable

1. Start at 0
2. Start at previous value on re-enable
3. Start at input-number on re-enable
4. ...

If these are all relevant use cases than I have to think about the implementation, maybe with a select entity for startup and one for re-enable.

And maybe hide them in the disabled section for the sake of simplicity?

[anssih]

Yeah, there are a lot.

Unfortunately I can't really tell how many combinations of those are worth it to be supported, I'm new to HA.

As noted, I'm fine with anything non-zero - and technically I can live with zero as well and I'll just add some extra startup filtering with templates/automations.

[anssih]

maybe with a select entity for startup and one for re-enable.

Could also use a configuration option, since I don't think this selection (if provided) is something that needs to be tracked by an entity.

[bvweerd]

Could also use a configuration option, since I don't think this selection (if provided) is something that needs to be tracked by an entity.

Would a use-case be that you e.g. would like to restart at 0 instead of previous value after a period of time? e.g. you have your ac turned off for a few days and would to to restart at 0, since the temperature conditions have changed. That would vote for an entity which you can (temporarily) change in e.g. an automation

[anssih]

Would a use-case be that you e.g. would like to restart at 0 instead of previous value after a period of time? e.g. you have your ac turned off for a few days and would to to restart at 0, since the temperature conditions have changed. That would vote for an entity which you can (temporarily) change in e.g. an automation

I would think in an A/C case the previous value would still have a better chance of being better guess than 0.

But I can indeed imagine there are some unusual use cases that want to switch back-and-forth between 0 and last-value starting points.
However, there is no need for a select entity even in that case, one could use the "provide starting output via entity" option and then just set that entity to 0 or the last output in the automation. More hassle, of course.

But I'm not opposed to entities, just wanted to remind that configuration options are an option, too. (And as noted, I'm new to HA so not sure which one would be the "normal" way to do this in HA).

[bvweerd]

I created v1.4.0-alpha with a select function to select how to (re)start the PID controller. Can you verify if this answers the request?

[anssih]

Thanks, seems to work fine :)

[anssih]

Though I notice Starting Output is in Configuration section and PID Start Mode is in Controls section, is that intentional?

I think reversed (or both configuration) would make more sense to me, but I don't mind that much. Just wanted to double-check it is as intended.

[bvweerd]

Though I notice Starting Output is in Configuration section and PID Start Mode is in Controls section, is that intentional?

I think reversed (or both configuration) would make more sense to me, but I don't mind that much. Just wanted to double-check it is as intended.

No, you're right. Just did not bother to fix all the details yet. I'm building the tests right now before merging, just wanted your feedback on the basics with the alpha version :-)

[bvweerd]

Fixed in v1.4.0