Merge pull request #250 from cakephp/fix-exception-messages

dereuromark · web-flow · commit 1cca24bc91c4 · 2024-01-05T13:55:55.000+01:00
Fix up exception messages.
diff --git a/src/Validation/AtValidation.php b/src/Validation/AtValidation.php
@@ -54,7 +54,7 @@ public static function postal(string $check): bool
      */
     public static function phone(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 
     /**
@@ -66,6 +66,6 @@ public static function phone(string $check): bool
      */
     public static function personId(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 }
diff --git a/src/Validation/AuValidation.php b/src/Validation/AuValidation.php
@@ -68,6 +68,6 @@ public static function phone(string $check): bool
      */
     public static function personId(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 }
diff --git a/src/Validation/BdValidation.php b/src/Validation/BdValidation.php
@@ -54,7 +54,7 @@ public static function postal(string $check): bool
      */
     public static function phone(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 
     /**
@@ -66,6 +66,6 @@ public static function phone(string $check): bool
      */
     public static function personId(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 }
diff --git a/src/Validation/BeValidation.php b/src/Validation/BeValidation.php
@@ -54,7 +54,7 @@ public static function postal(string $check): bool
      */
     public static function phone(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 
     /**
@@ -65,6 +65,6 @@ public static function phone(string $check): bool
      */
     public static function personId(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 }
diff --git a/src/Validation/CaValidation.php b/src/Validation/CaValidation.php
@@ -54,7 +54,7 @@ public static function postal(string $check): bool
      */
     public static function phone(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 
     /**
@@ -65,6 +65,6 @@ public static function phone(string $check): bool
      */
     public static function personId(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 }
diff --git a/src/Validation/ChValidation.php b/src/Validation/ChValidation.php
@@ -55,7 +55,7 @@ public static function postal(string $check): bool
      */
     public static function phone(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 
     /**
@@ -67,6 +67,6 @@ public static function phone(string $check): bool
      */
     public static function personId(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 }
diff --git a/src/Validation/CzValidation.php b/src/Validation/CzValidation.php
@@ -54,7 +54,7 @@ public static function postal(string $check): bool
      */
     public static function phone(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 
     /**
@@ -66,6 +66,6 @@ public static function phone(string $check): bool
      */
     public static function personId(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 }
diff --git a/src/Validation/DeValidation.php b/src/Validation/DeValidation.php
@@ -102,6 +102,6 @@ public static function dob(string $check): bool
      */
     public static function personId(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 }
diff --git a/src/Validation/FiValidation.php b/src/Validation/FiValidation.php
@@ -55,7 +55,7 @@ public static function postal(string $check): bool
      */
     public static function phone(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 
     /**
diff --git a/src/Validation/GbValidation.php b/src/Validation/GbValidation.php
@@ -52,7 +52,7 @@ public static function postal(string $check): bool
      */
     public static function phone(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 
     /**
@@ -64,6 +64,6 @@ public static function phone(string $check): bool
      */
     public static function personId(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 }
diff --git a/src/Validation/HrValidation.php b/src/Validation/HrValidation.php
@@ -53,7 +53,7 @@ public static function postal(string $check): bool
      */
     public static function phone(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 
     /**
@@ -65,6 +65,6 @@ public static function phone(string $check): bool
      */
     public static function personId(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 }
diff --git a/src/Validation/IdValidation.php b/src/Validation/IdValidation.php
@@ -67,7 +67,7 @@ public static function mobile(string $check): bool
      */
     public static function phone(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 
     /**
@@ -79,6 +79,6 @@ public static function phone(string $check): bool
      */
     public static function personId(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 }
diff --git a/src/Validation/InValidation.php b/src/Validation/InValidation.php
@@ -67,6 +67,6 @@ public static function phone(string $check): bool
      */
     public static function personId(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 }
diff --git a/src/Validation/ItValidation.php b/src/Validation/ItValidation.php
@@ -106,6 +106,6 @@ public static function cf(string $check): bool
      */
     public static function personId(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 }
diff --git a/src/Validation/JpValidation.php b/src/Validation/JpValidation.php
@@ -158,6 +158,6 @@ public static function zenkaku(string $check): bool
      */
     public static function personId(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 }
diff --git a/src/Validation/LvValidation.php b/src/Validation/LvValidation.php
@@ -42,7 +42,7 @@ class LvValidation extends LocalizedValidation
      */
     public static function postal(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 
     /**
@@ -54,7 +54,7 @@ public static function postal(string $check): bool
      */
     public static function phone(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 
     /**
diff --git a/src/Validation/MxValidation.php b/src/Validation/MxValidation.php
@@ -67,6 +67,6 @@ public static function postal(string $check): bool
      */
     public static function personId(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 }
diff --git a/src/Validation/PtValidation.php b/src/Validation/PtValidation.php
@@ -54,7 +54,7 @@ public static function postal(string $check): bool
      */
     public static function phone(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 
     /**
@@ -66,6 +66,6 @@ public static function phone(string $check): bool
      */
     public static function personId(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 }
diff --git a/src/Validation/RoValidation.php b/src/Validation/RoValidation.php
@@ -54,7 +54,7 @@ public static function postal(string $check): bool
      */
     public static function phone(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 
     /**
@@ -66,6 +66,6 @@ public static function phone(string $check): bool
      */
     public static function personId(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 }
diff --git a/src/Validation/RsValidation.php b/src/Validation/RsValidation.php
@@ -128,6 +128,6 @@ public static function jmbg(string $check): bool
      */
     public static function phone(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 }
diff --git a/src/Validation/SkValidation.php b/src/Validation/SkValidation.php
@@ -54,7 +54,7 @@ public static function postal(string $check): bool
      */
     public static function phone(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 
     /**
@@ -66,6 +66,6 @@ public static function phone(string $check): bool
      */
     public static function personId(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 }
diff --git a/src/Validation/TrValidation.php b/src/Validation/TrValidation.php
@@ -85,7 +85,7 @@ public static function personId(string $tckn): bool
      */
     public static function phone(string $check): bool
     {
-        throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));
+        throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
     }
 
     /**
diff --git a/tests/TestCase/Validation/TrValidationTest.php b/tests/TestCase/Validation/TrValidationTest.php
@@ -17,6 +17,7 @@
  */
 namespace Cake\Localized\Test\TestCase\Validation;
 
+use Cake\Http\Exception\NotImplementedException;
 use Cake\Localized\Validation\TrValidation;
 use Cake\TestSuite\TestCase;
 
@@ -56,4 +57,15 @@ public function testPersonId()
         $this->assertFalse(TrValidation::personId('01216166930'));
         $this->assertFalse(TrValidation::personId('31216166931'));
     }
+
+    /**
+     * @return void
+     */
+    public function testPhone(): void
+    {
+        $this->expectException(NotImplementedException::class);
+        $this->expectExceptionMessage('`Cake\Localized\Validation\TrValidation::phone()` Not implemented yet.');
+
+        TrValidation::phone('');
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public static function postal(string $check): bool`
`54`	`54`	`*/`
`55`	`55`	`public static function phone(string $check): bool`
`56`	`56`	`{`
`57`		`- throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));`
	`57`	+ throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`/**`
`@@ -66,6 +66,6 @@ public static function phone(string $check): bool`
`66`	`66`	`*/`
`67`	`67`	`public static function personId(string $check): bool`
`68`	`68`	`{`
`69`		`- throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));`
	`69`	+ throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
`70`	`70`	`}`
`71`	`71`	`}`
Original file line number	Diff line number	Diff line change
`@@ -68,6 +68,6 @@ public static function phone(string $check): bool`
`68`	`68`	`*/`
`69`	`69`	`public static function personId(string $check): bool`
`70`	`70`	`{`
`71`		`- throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));`
	`71`	+ throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
`72`	`72`	`}`
`73`	`73`	`}`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ public static function postal(string $check): bool`
`55`	`55`	`*/`
`56`	`56`	`public static function phone(string $check): bool`
`57`	`57`	`{`
`58`		`- throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));`
	`58`	+ throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`/**`
`@@ -67,6 +67,6 @@ public static function phone(string $check): bool`
`67`	`67`	`*/`
`68`	`68`	`public static function personId(string $check): bool`
`69`	`69`	`{`
`70`		`- throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));`
	`70`	+ throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
`71`	`71`	`}`
`72`	`72`	`}`
Original file line number	Diff line number	Diff line change
`@@ -102,6 +102,6 @@ public static function dob(string $check): bool`
`102`	`102`	`*/`
`103`	`103`	`public static function personId(string $check): bool`
`104`	`104`	`{`
`105`		`- throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));`
	`105`	+ throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
`106`	`106`	`}`
`107`	`107`	`}`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ public static function postal(string $check): bool`
`52`	`52`	`*/`
`53`	`53`	`public static function phone(string $check): bool`
`54`	`54`	`{`
`55`		`- throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));`
	`55`	+ throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`/**`
`@@ -64,6 +64,6 @@ public static function phone(string $check): bool`
`64`	`64`	`*/`
`65`	`65`	`public static function personId(string $check): bool`
`66`	`66`	`{`
`67`		`- throw new NotImplementedException(__d('localized', '%s Not implemented yet.'));`
	`67`	+ throw new NotImplementedException(__d('localized', '`{0}()` Not implemented yet.', __METHOD__));
`68`	`68`	`}`
`69`	`69`	`}`