Merge branch 'main' into test/app-worker-unit-tests

Author: cameri

.changeset/callback-check-payments-enabled.md

@@ -0,0 +1,5 @@
+---
+"nostream": patch
+---
+
+fix: check payments.enabled in callback route middleware

src/routes/callbacks/index.ts

@@ -12,7 +12,7 @@ const router: Router = Router()
 const requireProcessor = (name: string) =>
   (_req: Request, res: Response, next: NextFunction) => {
     const settings = createSettings()
-    if (settings.payments?.processor !== name) {
+    if (!settings.payments?.enabled || settings.payments.processor !== name) {
       res.status(403).send('Forbidden')
       return
     }

test/integration/features/callbacks/opennode-callback.feature.ts

@@ -36,8 +36,17 @@ Given('OpenNode callback processing is enabled', function () {
     ...settings,
     payments: {
       ...(settings?.payments ?? {}),
+      enabled: true,
       processor: 'opennode',
     },
+    paymentsProcessors: {
+      ...(settings?.paymentsProcessors ?? {}),
+      opennode: {
+        ...(settings?.paymentsProcessors?.opennode ?? {}),
+        baseURL: 'api.opennode.com',
+        callbackBaseURL: 'http://localhost:18808/callbacks/opennode',
+      },
+    },
   }
 
   process.env.OPENNODE_API_KEY = OPENNODE_TEST_API_KEY

test/unit/routes/callbacks.spec.ts

@@ -16,7 +16,7 @@ describe('callbacks router', () => {
     receivedBody = undefined
 
     createSettingsStub = Sinon.stub(settingsFactory, 'createSettings').returns({
-      payments: { processor: 'opennode' },
+      payments: { enabled: true, processor: 'opennode' },
     } as any)
 
     createOpenNodeCallbackControllerStub = Sinon.stub(openNodeControllerFactory, 'createOpenNodeCallbackController').returns({