test: increase unit coverage for CI

Author: Priyanshubhartistm

test/unit/handlers/request-handlers/get-health-request-handler.spec.ts

@@ -0,0 +1,27 @@
+import chai from 'chai'
+import sinon from 'sinon'
+import sinonChai from 'sinon-chai'
+
+import { getHealthRequestHandler } from '../../../../src/handlers/request-handlers/get-health-request-handler'
+
+chai.use(sinonChai)
+const { expect } = chai
+
+describe('getHealthRequestHandler', () => {
+  it('responds with OK plain text and calls next', () => {
+    const req = {} as any
+    const res = {
+      status: sinon.stub().returnsThis(),
+      setHeader: sinon.stub().returnsThis(),
+      send: sinon.stub().returnsThis(),
+    } as any
+    const next = sinon.stub()
+
+    getHealthRequestHandler(req, res, next)
+
+    expect(res.status).to.have.been.calledOnceWithExactly(200)
+    expect(res.setHeader).to.have.been.calledOnceWithExactly('content-type', 'text/plain; charset=utf8')
+    expect(res.send).to.have.been.calledOnceWithExactly('OK')
+    expect(next).to.have.been.calledOnce
+  })
+})

test/unit/handlers/subscribe-message-handler.spec.ts

@@ -236,6 +236,22 @@ describe('SubscribeMessageHandler', () => {
       await expect(promise).to.eventually.be.rejectedWith(error)
       expect(closeSpy).to.have.been.called
     })
+
+    it('destroys event stream if aborted', async () => {
+      const error = new Error('aborted')
+      error.name = 'AbortError'
+      isClientSubscribedToEventStub.returns(always(true))
+
+      const fetch = () => (handler as any).fetchAndSend(subscriptionId, filters)
+      const destroySpy = sandbox.spy(stream, 'destroy')
+
+      const promise = fetch()
+
+      stream.emit('error', error)
+
+      await expect(promise).to.eventually.be.rejectedWith(error)
+      expect(destroySpy).to.have.been.called
+    })
   })
 
   describe('.isClientSubscribedToEvent', () => {
@@ -350,5 +366,35 @@ describe('SubscribeMessageHandler', () => {
         'Too many filters: Number of filters per susbscription must be less then or equal to 1',
       )
     })
+
+    it('returns reason if subscription id is too long', () => {
+      settingsFactory.returns({
+        limits: {
+          client: {
+            subscription: {
+              maxSubscriptionIdLength: 5,
+            },
+          },
+        },
+      })
+
+      expect((handler as any).canSubscribe('123456', filters)).to.equal(
+        'Subscription ID too long: Subscription ID must be less or equal to 5',
+      )
+    })
+
+    it('returns undefined if subscription id matches max length', () => {
+      settingsFactory.returns({
+        limits: {
+          client: {
+            subscription: {
+              maxSubscriptionIdLength: 6,
+            },
+          },
+        },
+      })
+
+      expect((handler as any).canSubscribe('123456', filters)).to.be.undefined
+    })
   })
 })