From f8b4beab99d17eb850e70ab4f1cbe7b44dc49e60 Mon Sep 17 00:00:00 2001
From: Benjamin Drung <benjamin.drung@canonical.com>
Date: Thu, 30 Apr 2026 02:28:21 +0200
Subject: [PATCH] report: decode crash output to string in
 add_kernel_crash_info

The functions `Report.crash_signature_addresses` and
`Report._crash_signature_kernel_crash` expect the value for `Stacktrace`
to be a string.

So let `add_kernel_crash_info` set the value for `Stacktrace` as string
by decoding the `crash` output to UTF-8.

Bug: https://launchpad.net/bugs/2146806
---
 apport/report.py          | 3 ++-
 tests/unit/test_report.py | 8 ++++----
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/apport/report.py b/apport/report.py
index c828c8b63..30588f349 100644
--- a/apport/report.py
+++ b/apport/report.py
@@ -986,7 +986,8 @@ def add_kernel_crash_info(self) -> bool:
                 crash = subprocess.run(
                     command,
                     check=False,
-                    input=b"bt -a -f\nps\nrunq\nquit\n",
+                    encoding="UTF-8",
+                    input="bt -a -f\nps\nrunq\nquit\n",
                     stdout=subprocess.PIPE,
                     stderr=subprocess.STDOUT,
                 )
diff --git a/tests/unit/test_report.py b/tests/unit/test_report.py
index bfc6e3b40..3a4153d35 100644
--- a/tests/unit/test_report.py
+++ b/tests/unit/test_report.py
@@ -1596,7 +1596,7 @@ def test_add_kernel_crash_info_no_vmcore(self) -> None:
     def test_add_kernel_crash_info(self, run_mock: MagicMock) -> None:
         """add_kernel_crash_info() on a fake vmcore."""
         run_mock.return_value = subprocess.CompletedProcess(
-            args=MagicMock(), returncode=0, stdout=b"kernel stack trace", stderr=b""
+            args=MagicMock(), returncode=0, stdout="kernel stack trace", stderr=""
         )
         report = apport.report.Report("KernelCrash")
         report["VmCore"] = problem_report.CompressedValue(b"\x01" * 100, name="VmCore")
@@ -1607,7 +1607,7 @@ def test_add_kernel_crash_info(self, run_mock: MagicMock) -> None:
 
         self.assertTrue(report.add_kernel_crash_info())
 
-        self.assertEqual(report.get("Stacktrace"), b"kernel stack trace")
+        self.assertEqual(report.get("Stacktrace"), "kernel stack trace")
         run_mock.assert_called_once()
         called_cmd = run_mock.call_args[0][0]
         self.assertEqual(
@@ -1623,8 +1623,8 @@ def test_add_kernel_crash_info_fail(self, run_mock: MagicMock) -> None:
         run_mock.return_value = subprocess.CompletedProcess(
             args=MagicMock(),
             returncode=1,
-            stdout=b"read_maps: unable to read header from $vmcore, errno = 0",
-            stderr=b"",
+            stdout="read_maps: unable to read header from $vmcore, errno = 0",
+            stderr="",
         )
         report = apport.report.Report("KernelCrash")
         report["VmCore"] = b"\x01" * 100