dbus: platforms: softeners: move all universal specific logic out of FPGA trait#192
Draft
artiepoole wants to merge 3 commits into
Draft
dbus: platforms: softeners: move all universal specific logic out of FPGA trait#192artiepoole wants to merge 3 commits into
artiepoole wants to merge 3 commits into
Conversation
artiepoole
force-pushed
the
artie/universal-subcommand
branch
2 times, most recently
from
10c7cdc to
582c708
Compare
…FPGA trait implements two new dbus methods: - StatusInterface::universal - ControlInterface::universal functional changes: - set/get flags now universal only - read/write_property[_bytes] now universal only Signed-off-by: Artie Poole <stuart.poole@canonical.com>
Signed-off-by: Artie Poole <stuart.poole@canonical.com>
Updates tests to work with the new universal and dfx-mgr top-level CLI subcommands introduced in the last 3 commits. Changes: - daemon/tests: Update DBus proxy interfaces to use unified 'universal()' method instead of separate set_fpga_flags, write_property, read_property, etc. methods - daemon/tests: Remove duplicate xilinx_dfx_mgr tests that are now covered by universal tests (set_fpga_flags, write_property, read_property, get_fpga_flags) - tests/snap_testing: Add test_universal_command.py with tests for the new 'universal' command (read/write operations) - tests/snap_testing: Add test_dfx_mgr_command.py with tests for the new 'dfx-mgr' command - they require running like `fpgad dfx-mgr -- <args>` - tests/snap_testing: Add help tests for universal and dfx-mgr commands - cli/README.md: Update universal command documentation to reflect actual subcommand names (read_property, write_flags, etc.) Signed-off-by: Artie Poole <stuart.poole@canonical.com>
artiepoole
force-pushed
the
artie/universal-subcommand
branch
from
582c708 to
c55c9e2
Compare
artiepoole
force-pushed
the
artie/universal-subcommand
branch
from
c55c9e2 to
37b11f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds 2 dbus methods:
removes 5 dbus methods: