Fix KeyError when queued_at field is missing from GitHub API

The GitHub API may not always return queued_at for older jobs.
Changed to use .get() method and made queued_at optional in type
definitions. The metrics calculation now falls back to created_at
when queued_at is not available, maintaining backward compatibility.

Author: yanksyoon

.DS_Store

@@ -468,8 +468,16 @@ def _to_job_info(job: dict) -> JobInfo:
         # datetime strings should be in ISO 8601 format, but they can also use Z instead of +00:00,
         # which is not supported by datetime.fromisoformat
         created_at = datetime.fromisoformat(job["created_at"].replace("Z", "+00:00"))
-        queued_at = datetime.fromisoformat(job["queued_at"].replace("Z", "+00:00"))
-        started_at = datetime.fromisoformat(job["started_at"].replace("Z", "+00:00"))
+        queued_at_raw = job.get("queued_at")
+        queued_at = (
+            datetime.fromisoformat(queued_at_raw.replace("Z", "+00:00")) if queued_at_raw else None
+        )
+        started_at_raw = job.get("started_at")
+        started_at = (
+            datetime.fromisoformat(started_at_raw.replace("Z", "+00:00"))
+            if started_at_raw
+            else None
+        )
         # conclusion could be null or an empty dictionary per api schema, so we need to handle
         # that though we would assume that it should always be present, as the job should be
         # finished.

github-runner-manager/.DS_Store

@@ -50,6 +50,11 @@ def job(
     except (JobNotFoundError, PlatformApiError) as exc:
         raise GithubMetricsError from exc
 
-    queue_duration = (job_info.started_at - job_info.queued_at).total_seconds()
+    queued_or_created_at = job_info.queued_at or job_info.created_at
+    queue_duration = (
+        (job_info.started_at - queued_or_created_at).total_seconds()
+        if job_info.started_at
+        else None
+    )
 
     return GithubJobMetrics(queue_duration=queue_duration, conclusion=job_info.conclusion)

github-runner-manager/src/github_runner_manager/github_client.py

@@ -250,7 +250,7 @@ class JobInfo:
     """
 
     created_at: datetime
-    queued_at: datetime
-    started_at: datetime
+    queued_at: datetime | None
+    started_at: datetime | None
     # A str until we realise a common pattern, use a simple str
     conclusion: str | None

github-runner-manager/src/github_runner_manager/metrics/github.py

@@ -127,8 +127,8 @@ class JobInfo(BaseModel):
 
     job_id: int
     created_at: datetime
-    queued_at: datetime
-    started_at: datetime
+    queued_at: Optional[datetime]
+    started_at: Optional[datetime]
     conclusion: Optional[JobConclusion]
     status: JobStatus