no sql spans

[kulliax]

Hi @sjvans,

we have not had any sql spans in our traces (CLS) for some time now. Could this be related to the pull request #305? Unfortunately I can't find any suitable documentation for the Hana driver, can it be linked here?
These are visible in the console output

@cap-js/asyncapi: 1.0.3
@cap-js/cds-typer: 0.35.0
@cap-js/cds-types: 0.11.0
@cap-js/db-service: 1.20.2
@cap-js/hana: 1.9.1
@cap-js/openapi: 1.2.3
@cap-js/sqlite: 1.11.1
@cap-js/telemetry: 1.4.0
@sap/cds: 8.9.4
@sap/cds-compiler: 5.9.4
@sap/cds-dk: 8.9.5
@sap/cds-dk (global): 8.9.3
@sap/cds-fiori: 1.4.1
@sap/cds-foss: 5.0.1
@sap/cds-mtxs: 2.7.2
@sap/eslint-plugin-cds: 3.2.0
Node.js: v22.13.1

[soccermax]

@sjvans

The issue occurs after the default change of _hana_prom from false to true.

const { _tx, _hana_prom, _wrap_hana } = cds.env.requires.telemetry.tracing

This leads to change of the passed parameters in the function:

function _addAttributes(span, fn, that, options, args, parent) {
  _setAttributes(span, _getStaticAttributes(fn))

  // needed for sampling decision (cf. shouldSample)
  if (cds.context.http?.req) {
    const url_path = cds.context.http.req.baseUrl + cds.context.http.req.path
    span.setAttribute('url.path', url_path)
    span.setAttribute('http.target', url_path) //> http.target is deprecated
  }

  if (that.dbc || options.sql) {

options.sql is always undefined in the case of _hana_prom: true because in that case the SQL is in the args parameter.

[sjvans]

hi @soccermax

thanks for the analysis! i'll patch ASAP.

best,
sebastian