Skip to content

chore: guard against cds10 until prepped#418

Merged
sjvans merged 1 commit into
mainfrom
prep-for-cds10
Apr 28, 2026
Merged

chore: guard against cds10 until prepped#418
sjvans merged 1 commit into
mainfrom
prep-for-cds10

Conversation

@sjvans
Copy link
Copy Markdown
Contributor

@sjvans sjvans commented Apr 28, 2026

Guard Against CDS 10 by Restricting Peer Dependency Version Range

Chore

🔧 Updated the @sap/cds peer dependency version range in package.json to explicitly exclude CDS version 10 until the package is prepared to support it. Related dev dependency version ranges were also tightened for consistency.

Changes

  • package.json:
    • Changed @sap/cds peer dependency from >=8 to ^8 || ^9, preventing accidental resolution to CDS 10.
    • Tightened @cap-js/cds-test dev dependency from >=0 to ^0.
    • Tightened @cap-js/sqlite dev dependency from >=1 to ^1 || ^2.
    • Updated @sap/cds-mtxs dev dependency from >=2 to ^2 || ^3.
  • 🔄 Regenerate and Update Summary
PR Bot Information

Version: 1.20.33

  • Summary Prompt: Default Prompt
  • LLM: anthropic--claude-4.6-sonnet
  • File Content Strategy: Full file content
  • Correlation ID: d038cf21-0707-45ec-b548-214367285b6b
  • Event Trigger: pull_request.opened
  • Output Template: Default Template

Co-authored-by: Copilot <copilot@github.com>
Copy link
Copy Markdown
Contributor

@hyperspace-insights hyperspace-insights Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The single substantive issue in this PR is the unintentionally restrictive ^0 range for @cap-js/cds-test: unlike the other packages (which had explicit major-version upper bounds worth tightening), ^0 will exclude any 1.x+ release of that package that may already exist or ship in the future — which is almost certainly not the intended behaviour given the PR's stated goal of guarding only against cds@10. The rest of the changes (^8 || ^9, ^1 || ^2, ^2 || ^3) are correct semver ranges for the stated purpose.

PR Bot Information

Version: 1.20.33

  • File Content Strategy: Full file content
  • Correlation ID: d038cf21-0707-45ec-b548-214367285b6b
  • LLM: anthropic--claude-4.6-sonnet
  • Event Trigger: pull_request.opened

Comment thread package.json
"devDependencies": {
"@cap-js/cds-test": ">=0",
"@cap-js/sqlite": ">=1",
"@cap-js/cds-test": "^0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic Error: ^0 blocks all stable releases of @cap-js/cds-test

The ^0 range in npm semver has special behaviour: when the major version is 0, the caret operator only allows patch-level changes (0.x.y0.x.*). More critically, ^0 is equivalent to >=0.0.0 <1.0.0 — it excludes any 1.x or later release. The previous >=0 was intentional to allow any release regardless of major version.

If the goal here (matching the rest of the PR) is to guard against a future breaking major while still allowing all current stable versions, the range should explicitly enumerate the known-good majors, or simply remain >=0 if no upper guard is needed for this package.

Suggested change
"@cap-js/cds-test": "^0",
"@cap-js/cds-test": ">=0",

Double-check suggestion before committing. Edit this comment for amendments.


Please provide feedback on the review comment by checking the appropriate box:

  • 🌟 Awesome comment, a human might have missed that.
  • ✅ Helpful comment
  • 🤷 Neutral
  • ❌ This comment is not helpful

@sjvans sjvans merged commit f586bfc into main Apr 28, 2026
12 checks passed
@sjvans sjvans deleted the prep-for-cds10 branch April 28, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant