Skip to content

chore: guard against cds10 until prepped #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sjvans merged 1 commit into from
Apr 28, 2026
Merged

chore: guard against cds10 until prepped #418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@
"@opentelemetry/semantic-conventions": "^1.36"
},
"peerDependencies": {
"@sap/cds": ">=8"
"@sap/cds": "^8 || ^9"
},
"devDependencies": {
"@cap-js/cds-test": ">=0",
"@cap-js/sqlite": ">=1",
"@cap-js/cds-test": "^0",
Copy link
Copy Markdown
Contributor

@hyperspace-insights hyperspace-insights Bot Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic Error: ^0 blocks all stable releases of @cap-js/cds-test

The ^0 range in npm semver has special behaviour: when the major version is 0, the caret operator only allows patch-level changes (0.x.y → 0.x.*). More critically, ^0 is equivalent to >=0.0.0 <1.0.0 — it excludes any 1.x or later release. The previous >=0 was intentional to allow any release regardless of major version.

If the goal here (matching the rest of the PR) is to guard against a future breaking major while still allowing all current stable versions, the range should explicitly enumerate the known-good majors, or simply remain >=0 if no upper guard is needed for this package.

Suggested change
"@cap-js/cds-test": "^0",
"@cap-js/cds-test": ">=0",

Double-check suggestion before committing. Edit this comment for amendments.

Please provide feedback on the review comment by checking the appropriate box:

  • 🌟 Awesome comment, a human might have missed that.
  • ✅ Helpful comment
  • 🤷 Neutral
  • ❌ This comment is not helpful

"@cap-js/sqlite": "^1 || ^2",
"@cap-js/telemetry": "file:.",
"@dynatrace/oneagent-sdk": "^1.5.0",
"@grpc/grpc-js": "^1.9.14",
Expand All @@ -43,7 +43,7 @@
"@opentelemetry/exporter-trace-otlp-proto": "^0.57.0",
"@opentelemetry/host-metrics": "^0.36.0",
"@opentelemetry/instrumentation-runtime-node": "^0.17.0",
"@sap/cds-mtxs": ">=2",
"@sap/cds-mtxs": "^2 || ^3",
"axios": "^1.6.7",
"chai": "^4.4.1",
"chai-as-promised": "^7.1.1",
Expand Down
Loading