Skip to content

Add a function that fills NaN in a triangle with 0 #656

@henrydingliu

Description

@henrydingliu

Description

fillna(0) doesn't do this. Not sure if intentional.

Is your feature request aligned with the scope of the package?

  • Yes, absolutely!
  • No, but it's still worth discussing.
  • N/A (this request is not a codebase enhancement).

Describe the solution you'd like, or your current workaround.

Not sure if we should change fillna(0) or make a new function.

fillna(0) is used a few times elsewhere in the package.

Do you have any additional supporting notes?

run the following to see

raa = cl.load_sample('raa')
print(raa-raa)
print((raa-raa).fillna(0))
print((raa-raa).fillna(1))

Metadata

Metadata

Assignees

No one assigned

    Labels

    Effort > Brief 🐇Small tasks expected to take a few hours up to a couple of days.Great First Contribution! 🌱Beginner friendly tickets with narrow scope and huge impact. Perfect to join our community!Impact > Moderate 🔶User-visible but non-breaking change. Treated like a minor version bump (e.g., 0.6.5 → 0.7.0).

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions