Don't auto-complete recipe names for arguments

[ABDsheikho]

I have a suggestion to add a setting that prevents the just command from being called with multiple recipes, and prevents the just command from suggesting other recipes as autocomplete (and start suggesting for example current directory files).

The setting should be similar to calling the just command with the --one option, and could be something like allow-multiple-recipes (which is true by default) or only-one-recipe (which is false).

[casey]

If I understand correctly, this is so that the autocomplete scripts will suggest files instead of recipes. I think that this is an improvement that could be made to the autocomplete scripts without adding a flag, if a recipe takes arguments, the autocomplete scripts would ideally suggest files instead of more recipes.

[ABDsheikho]

Not just that. If all of my recipes require file arguments, then I'll be forced to pass --one flag each time I'm invoking a recipe, plus it shows that the intended use case of this justfile is to be used one recipe at a time.

On a different note:
Recipes that require an arbitrary number of arguments should stop suggesting other recipes.

[casey]

But to be clear, does this require a setting? Shouldn't the completion scripts just not suggest recipes in contexts where only arguments are accepted?

[ABDsheikho]

No it doesn't have to be. A work on the completion script can work fine.

But you'll lose something like getting an instant error when trying to run multiple commands at once even if you didn't pass the --one option.

However, I understand if you are trying to lower the level of changes required to add/fix this issue, but I'm just suggesting. If it works fine and as expected, then I'll probably wouldn't have added this issue. (I'm good at compromising)

Awesome tool, and thanks for your effort.

[casey]

I switched to using Clap's dynamic completion engine in #3167. The new completion engine calls into the just binary to get completions. This allows us to implement custom completion logic in Rust for all supported shells, instead of having to patch in support for each individual shell.

I created #2406 to track improvements to the new completion engine in one place.

I included this issue in the above issue. Using the new completion engine should make this more tractable, since this can now be implemented in Rust.

[karimknaebel]

I just updated from 1.46, and this disrupted my workflow. I usually write just <recipe> <file_name_arg> and tab complete the file name. It only suggests other recipes now instead of files. Fish shell.

[casey]

@karimknaebel I was going to try to be clever about this, and try to only complete filenames when they would be valid. However, I think it's much more annoying when a completion script won't complete filenames than when it completes filenames in places that they're not valid. In #3299 I changed the argument completer so that it completes filenames, regardless of whether they would be valid or not. I think trying to make it clever involves too many edge cases.

[karimknaebel]

Thanks! I downgraded to an older version until the next release comes out.

[benkeil]

Will this be fixed? it's basically unusable right now