From 0047113f789bdf99b5edb7996cccaa737b3a19b6 Mon Sep 17 00:00:00 2001 From: Vince Broz Date: Fri, 29 Aug 2025 09:04:40 -0400 Subject: [PATCH 1/2] Put continue_on_error at job level --- .github/workflows/linting.yml | 2 +- .github/workflows/rspec.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml index 8abbf51ef..9f6f0527a 100644 --- a/.github/workflows/linting.yml +++ b/.github/workflows/linting.yml @@ -96,6 +96,7 @@ jobs: run: bundle exec rbs validate rubocop_todo: name: .rubocop_todo.yml + continue-on-error: true runs-on: ubuntu-latest steps: @@ -113,7 +114,6 @@ jobs: run: bundle exec rubocop -c .rubocop.yml - name: Run RuboCop against todo file - continue-on-error: true run: | bundle exec rubocop --auto-gen-config --no-exclude-limit --no-offense-counts --no-auto-gen-timestamp if [ -n "$(git status --porcelain)" ] diff --git a/.github/workflows/rspec.yml b/.github/workflows/rspec.yml index ecc3d9771..b044acf43 100644 --- a/.github/workflows/rspec.yml +++ b/.github/workflows/rspec.yml @@ -52,6 +52,7 @@ jobs: run: bundle exec rake spec undercover: runs-on: ubuntu-latest + continue-on-error: true steps: - uses: actions/checkout@v3 with: @@ -69,4 +70,3 @@ jobs: run: bundle exec rake spec - name: Check PR coverage run: bundle exec rake undercover - continue-on-error: true From d413ebf463515407a7409d277a287487ef53b47c Mon Sep 17 00:00:00 2001 From: Vince Broz Date: Tue, 30 Sep 2025 10:03:07 -0400 Subject: [PATCH 2/2] Ratchet rubocop todo --- .rubocop_todo.yml | 8 -------- 1 file changed, 8 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 4745544d0..8f6d96a69 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -34,7 +34,6 @@ Gemspec/OrderedDependencies: # Configuration parameters: Severity. Gemspec/RequireMFA: Exclude: - - 'solargraph.gemspec' - 'spec/fixtures/rdoc-lib/rdoc-lib.gemspec' - 'spec/fixtures/rubocop-custom-version/specifications/rubocop-0.0.0.gemspec' @@ -89,13 +88,6 @@ Layout/EmptyLineBetweenDefs: Layout/EmptyLines: Enabled: false -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines, beginning_only, ending_only -Layout/EmptyLinesAroundClassBody: - Exclude: - - 'lib/solargraph/rbs_map/core_map.rb' - # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines