File type question (#681)#6
Merged
Merged
Conversation
* Circumvent number on string error, resolves PoetOS#538. (PoetOS#563) * Add file question type Fix upload when several file upload questions are used. - Adjust siganture of methods to their parent - Limit the files to upload to one for each question - Use questionaire id for file draft area instead of question id in the questionaire. Fix handling of file uploads - allow upload of one file only. - new submit does not load previously existing files. Change refence of file.itemid to questionnaire_response_file.id update existing files.itemid to questionnaire_response_file.id Improvements to satisfy code checker. Make the file upload work with required setting, fix delete of records * Make sid public, because its already used via #[\AllowDynamicProperties] Fix cleanup of old file responses. Add backup/restore handling for file response type. * Fix restore of files in backup. --------- Co-authored-by: Luca Bösch <luca.boesch@bfh.ch> Co-authored-by: Laurent David <lmedavid@gmail.com>
djarran
force-pushed
the
MOODLE_404_STABLE_file_type
branch
from
8270d12 to
dee1255
Compare
|
Thanks @djarran looks good to me. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Cherry-pick the changes made in PoetOS#681. This change was only made on the
MOODLE_500_STABLEbranch and the maintainer did not want this backported to the upstream `MOODLE_404_STABLE branch.Change has been manually tested. Behat tests also pass in CI
Testing instructions:
FileCommit message:
Circumvent number on string error, resolves number on string error PoetOS/moodle-mod_questionnaire#538. (Circumvent number on string error, resolves #538. PoetOS/moodle-mod_questionnaire#563)
Add file question type
Fix upload when several file upload questions are used.
Fix handling of file uploads
Change refence of file.itemid to questionnaire_response_file.id
update existing files.itemid to questionnaire_response_file.id
Improvements to satisfy code checker.
Make the file upload work with required setting, fix delete of records
Make sid public, because its already used via #[\AllowDynamicProperties] Fix cleanup of old file responses.
Add backup/restore handling for file response type.
Fix restore of files in backup. ---------