From 487365f4215909e60d97b24264d604556240eff3 Mon Sep 17 00:00:00 2001 From: Gerry Campion Date: Thu, 18 Jun 2026 17:35:53 -0400 Subject: [PATCH 1/3] support detailed markdown diff --- .github/workflows/validate-published-rules.yml | 1 + scripts/validate_published_rules.py | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/validate-published-rules.yml b/.github/workflows/validate-published-rules.yml index 025d6f5ea..a7d901b2b 100644 --- a/.github/workflows/validate-published-rules.yml +++ b/.github/workflows/validate-published-rules.yml @@ -86,6 +86,7 @@ jobs: cd engine ../venv/bin/pip install . --group dev cd .. + venv/bin/pip install tabulate # ----------------------------------------------------------------------- # 5. Run validation for every Published rule # ----------------------------------------------------------------------- diff --git a/scripts/validate_published_rules.py b/scripts/validate_published_rules.py index c645c163a..81198f1ae 100644 --- a/scripts/validate_published_rules.py +++ b/scripts/validate_published_rules.py @@ -104,10 +104,8 @@ def _build_failure_detail(record: dict) -> str: ) diff_file = record["_diff_file"] if diff_file and os.path.isfile(diff_file): - lines.append("```diff") with open(diff_file) as fh: lines.append(fh.read()) - lines.append("```") lines.append("") return "\n".join(lines) From e830d43bc7beb36aa4f10ff91359fed5bc24c002 Mon Sep 17 00:00:00 2001 From: Gerry Campion Date: Mon, 22 Jun 2026 12:20:10 -0400 Subject: [PATCH 2/3] upload actual in artifact instead of expectd --- .github/workflows/validate-published-rules.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/validate-published-rules.yml b/.github/workflows/validate-published-rules.yml index a7d901b2b..77b0416ce 100644 --- a/.github/workflows/validate-published-rules.yml +++ b/.github/workflows/validate-published-rules.yml @@ -117,7 +117,7 @@ jobs: with: name: published-rules-validation-${{ github.run_id }} path: | - open-rules/Published/**/results/results.csv + open-rules/Published/**/results/actual.csv summary_table.md detail_report.md if-no-files-found: warn From dae69332c4a62536891981fb7d74a72615aca560 Mon Sep 17 00:00:00 2001 From: Gerry Campion Date: Mon, 22 Jun 2026 13:11:39 -0400 Subject: [PATCH 3/3] save expected results too --- .github/workflows/validate-published-rules.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/validate-published-rules.yml b/.github/workflows/validate-published-rules.yml index 77b0416ce..ef53f5981 100644 --- a/.github/workflows/validate-published-rules.yml +++ b/.github/workflows/validate-published-rules.yml @@ -118,6 +118,7 @@ jobs: name: published-rules-validation-${{ github.run_id }} path: | open-rules/Published/**/results/actual.csv + open-rules/Published/**/results/expected.csv summary_table.md detail_report.md if-no-files-found: warn