Skip to content

Commit 06cff40

Browse files
Merge pull request #194 from mikedanese:fix
PiperOrigin-RevId: 592078971
2 parents cf3d719 + 784a981 commit 06cff40

4 files changed

Lines changed: 34 additions & 22 deletions

File tree

parser/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ java_library(
2626
java_library(
2727
name = "cel_g4_visitors",
2828
visibility = ["//visibility:public"],
29-
exports = ["//parser/src/main/java/dev/cel/parser:cel_g4_visitors"],
29+
exports = ["//parser/src/main/java/dev/cel/parser/gen:cel_g4_visitors"],
3030
)
3131

3232
java_library(

parser/src/main/java/dev/cel/parser/BUILD.bazel

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
load("//:antlr.bzl", "antlr4_java_combined")
2-
31
package(
42
default_applicable_licenses = ["//:license"],
53
default_visibility = [
@@ -44,7 +42,6 @@ java_library(
4442
tags = [
4543
],
4644
deps = [
47-
":cel_g4_visitors",
4845
":macro",
4946
":operator",
5047
":parser_builder",
@@ -54,6 +51,7 @@ java_library(
5451
"//common/annotations",
5552
"//common/ast",
5653
"//common/internal",
54+
"//parser:cel_g4_visitors",
5755
"@maven//:com_google_errorprone_error_prone_annotations",
5856
"@maven//:com_google_guava_guava",
5957
"@maven//:org_antlr_antlr4_runtime",
@@ -103,24 +101,6 @@ java_library(
103101
],
104102
)
105103

106-
antlr4_java_combined(
107-
name = "cel_g4",
108-
src = "CEL.g4",
109-
listener = False,
110-
package = "cel.parser.internal",
111-
visitor = True,
112-
)
113-
114-
java_library(
115-
name = "cel_g4_visitors",
116-
srcs = [":cel_g4"],
117-
tags = [
118-
],
119-
deps = [
120-
"@maven//:org_antlr_antlr4_runtime",
121-
],
122-
)
123-
124104
java_library(
125105
name = "unparser",
126106
srcs = UNPARSER_SOURCES,
Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
"""
2+
The generated parser is kept seperate from //parser/src/main/java/dev/cel/parser
3+
to avoid a path conflict with parser/src/main/java/dev/cel/parser/CelParser.java
4+
that causes build failures on filesystems with case-insensitive paths (e.g. macOS).
5+
"""
6+
7+
load("//:antlr.bzl", "antlr4_java_combined")
8+
9+
package(
10+
default_applicable_licenses = ["//:license"],
11+
)
12+
13+
antlr4_java_combined(
14+
name = "cel_g4",
15+
src = "CEL.g4",
16+
listener = False,
17+
package = "cel.parser.internal",
18+
visitor = True,
19+
)
20+
21+
java_library(
22+
name = "cel_g4_visitors",
23+
srcs = [":cel_g4"],
24+
tags = [
25+
],
26+
visibility = [
27+
"//parser:__pkg__",
28+
],
29+
deps = [
30+
"@maven//:org_antlr_antlr4_runtime",
31+
],
32+
)
File renamed without changes.

0 commit comments

Comments
 (0)