Bug: Inactive Peninsula is too big

[martinengelke]

In inactive state Peninsula is bigger than the standard notch and thus hiding the menu:

I just recognised that you can not screenshot the notch (2nd picture) :P

[celve]

The notch size is obtained directly from NSScreen.notchSize, so it should match your physical notch. Could you please check if the notch extends beyond the original notch on both the left and right sides?

[martinengelke]

No it’s just the right side, I guess it’s taken for the notifications.

[celve]

Have you add any app in the notification panel? And does it always extend beyond the notch no matter whether there is a notification?

[martinengelke]

I added Mail.app, it's always there, maybe because I always have some unread mails xD ?
If I delete Mail.app from Notifications and restart Peninsula, it's gone.

[celve]

I see the issue now. It's meant to display the total number of unread notifications, but it's not working because I forgot to handle the large number.

[martinengelke]

Cool,
btw: Your settings are creating a NotchDrop Folder in Documents, which is storing the settings as well as the attachments.
I would be fine with having the settings in in my ~/.config/peninsula/config/
and the attachments in ~/.tmp ?

Edit: Better read this before storing in tmp, since it gets auto-deleted after a period of time:
https://developer.apple.com/library/archive/documentation/Security/Conceptual/SecureCodingGuide/Articles/RaceConditions.html#//apple_ref/doc/uid/TP40002585-SW15

[celve]

Cool, btw: Your settings are creating a NotchDrop Folder in Documents, which is storing the settings as well as the attachments. I would be fine with having the settings in in my ~/.config/peninsula/config/ and the attachments in ~/.tmp ?

Edit: Better read this before storing in tmp, since it gets auto-deleted after a period of time: https://developer.apple.com/library/archive/documentation/Security/Conceptual/SecureCodingGuide/Articles/RaceConditions.html#//apple_ref/doc/uid/TP40002585-SW15

Thanks for pointing out. It should not be stored in documents. I will fix the auto cleanup issue too.

[martinengelke]

Its smaller now, but there is something left ?

[celve]

Yes, I will implement an invisible style in the next release.