Conversation
in gf_w32_cfmgk_multiply_region_from_single(), follow warning is
reported by gcc:
gf-complete/src/gf_w32.c:410:5: warning: ‘a’ may be used uninitialized
in this function [-Wmaybe-uninitialized]
g = _mm_insert_epi64 (a, g_star, 0);
^
actually, we are using `a` as a dummy parameter for initializing `g` and
`q`. and only the lower lower 64 bits of them are used when doing
calculation. but their lower 64 bits are always initialized using
_mm_insert_epi64(). so this is a false alarm.
but we can silence this warning by moving the statement initializing `a`
up before passing it to _mm_insert_epi64(). this change does not hurt
the performance.
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 9fbc442)
Correct invalid check for pclmul support. Was checking SSE3 (1 << 0) vs. PCLMUL (1 << 1). Fixes: http://tracker.ceph.com/issues/18092 Signed-off-by: John Coyle <dx9err@gmail.com> (cherry picked from commit 7c2fcc5)
The type of expression '1<<31' is signed int and this causes cppcheck to issue the following warning. src/gf_w32.c:681]: (error) Signed integer overflow for expression '1<<31'. Signed-off-by: Brad Hubbard <bhubbard@redhat.com> (cherry picked from commit 2700e1b)
Resolve cppcheck Signed integer overflow errors See merge request !22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We transfer the project under Windows and compile it with VS2019
You can refer to the link below
https://github.com/XXJG/gf-complete-Windows-VS