Computing breakages with Maven 4

[algomaster99]

Fix Summary by Category

All logs live here.

Category	Count	Fix
PARENT_POM_UNRESOLVABLE	54	- ❓
ENFORCER_SESSION_CAST	48	Upgrade maven-enforcer-plugin to 3.4.0+ ✔️
NETWORK_REPO_ERROR	23	-
PLUGIN_EXPRESSION_EVALUATOR_API	22	Upgrade maven-enforcer-plugin to 3.4.0+ (removes use of the deleted PluginParameterExpressionEvaluator constructor) ✔️
PLUGIN_GETGOALS_API	18	Upgrade maven-shade-plugin to 3.5.0+ (removes call to deleted Plugin.getGoals()) ✔️
DEPENDENCY_LOCK_MISMATCH	13	-
DUPLICATE_DEPENDENCY	10	Remove the duplicate entry from <dependencyManagement> in pom.xml, keeping only one version ✔️
PARENT_POM_CYCLE	9	-
SESSION_CONTAINER_NULL	7	-
JGITVER_EXTENSION	6	-
TAKARI_LIFECYCLE	4	Replace takari-lifecycle-plugin with standard maven-compiler-plugin + maven-jar-plugin (Takari is abandoned and incompatible with Maven 4) ✔️

This is the preliminary result when upgraded to maven 4 and Java 17 for all the datapoints in the dataset.
✔️ : indicates that the fix indeed is working.
I will verify the rest of them and propose it to the apache community.

[algomaster99]

PARENT_POM_UNRESOLVABLE

It happens because the repository in pom declares https://repo.jenkins-ci.org/public/ and then building with maven 4 results in an error:

[ERROR] Failed to execute goal on project untitled: Could not resolve dependencies for project io.algomaster99:untitled:jar:1.0-SNAPSHOT
[ERROR] dependency: org.jenkins-ci.plugins:plugin:pom:4.38 (compile)
[ERROR]         Prefix org/jenkins-ci/plugins/plugin/4.38/plugin-4.38.pom NOT allowed from repo.jenkins-ci.org (https://repo.jenkins-ci.org/public/, default, releases+snapshots)
[ERROR]         org.jenkins-ci.plugins:plugin:pom:4.38 was not found in https://repo.maven.apache.org/maven2 during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of central has elapsed or updates are forced

Changing it to https://repo.jenkins-ci.org/releases/ fixes for this minimal POC

<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0"
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>

    <groupId>io.algomaster99</groupId>
    <artifactId>untitled</artifactId>
    <version>1.0-SNAPSHOT</version>

    <properties>
        <maven.compiler.source>21</maven.compiler.source>
        <maven.compiler.target>21</maven.compiler.target>
        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    </properties>

    <dependencies>
        <dependency>
            <groupId>org.jenkins-ci.plugins</groupId>
            <artifactId>plugin</artifactId>
            <version>4.38</version>
            <type>pom</type>
            <scope>compile</scope>
        </dependency>
    </dependencies>

    <repositories>
        <repository>
            <id>repo.jenkins-ci.org</id>
            <url>https://repo.jenkins-ci.org/releases/</url>
        </repository>
    </repositories>
    <pluginRepositories>
        <pluginRepository>
            <id>repo.jenkins-ci.org</id>
            <url>https://repo.jenkins-ci.org/releases/</url>
        </pluginRepository>
    </pluginRepositories>\
</project>

However, it does not fix for https://github.com/chains-project/bump/blob/main/data/benchmark/f412c0f6f2bfd2a7aa3522b0f989f6b920a66a64.json.

[algomaster99]

DUPLICATE_DEPENDENCY

For duplicate dependencies, Maven 3 used to throw a warning.

[WARNING] 
[WARNING] Some problems were encountered while building the effective model for de.hilling.junit.cdi:cdi-test-docs:jar:3.2.2-SNAPSHOT
[WARNING] 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.hibernate:hibernate-entitymanager:jar -> version 5.6.0.Final vs 5.5.7.Final @ de.hilling.junit.cdi:cdi-test:3.2.2-SNAPSHOT, /tmp/cdi-test/pom.xml, line 249, column 25
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for de.hilling.junit.cdi:cdi-test:pom:3.2.2-SNAPSHOT
[WARNING] 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.hibernate:hibernate-entitymanager:jar -> version 5.6.0.Final vs 5.5.7.Final @ line 249, column 25
[WARNING] 
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING] 
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.

However, in Maven 4, it fails

[ERROR]   The project de.hilling.junit.cdi:cdi-test:pom:3.2.2-SNAPSHOT (/cdi-test/pom.xml) has 1 error
[ERROR]     'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.hibernate:hibernate-entitymanager:jar -> version 5.5.7.Final vs 5.6.0.Final @ de.hilling.junit.cdi:cdi-test:3.2.2-SNAPSHOT, file:///cdi-test/pom.xml, line 250, column 13

Source: https://github.com/guhilling/cdi-test/blob/3f30dfff617fd652412260ecf648a25769a27101/pom.xml#L198-L253