Core:collect_linux_badge_info error: AttributeError("'NoneType' object has no attribute 'text'")

[cdolfi]

Exception | AttributeError("'NoneType' object has no attribute 'text'")

Stack Trace

Traceback (most recent call last):
  File "/collectoss/collectoss/tasks/github/repo_info/core.py", line 286, in badges_model
    response_data = response.json()
                    ^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'json'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/collectoss/.venv/lib/python3.11/site-packages/celery/app/trace.py", line 453, in trace_task
    R = retval = fun(*args, **kwargs)
                 ^^^^^^^^^^^^^^^^^^^^
  File "/collectoss/.venv/lib/python3.11/site-packages/celery/app/trace.py", line 736, in __protected_call__
    return self.run(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/collectoss/collectoss/tasks/github/repo_info/tasks.py", line 37, in collect_linux_badge_info
    badges_model(logger, repo_git, repo.repo_id, session)
  File "/collectoss/collectoss/tasks/github/repo_info/core.py", line 288, in badges_model
    response_data = json.loads(json.dumps(response.text))
                                          ^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'text'
-- | --

[MoralCode]

This is happening because this task is using a deprecated method for hitting an API.

This deprecated method is returning none in cases where there is a: TimeoutError, TimeoutException, NetworkError, or ProtocolError

a lack of handling of these None's by the caller is causing these errors

[MoralCode]

... This badges_model function isnt even trying to hit the github api, its trying to use
cii_endpoint = "https://bestpractices.coreinfrastructure.org/projects.json?pq="

This suggests we probably need a more generic API interface class than just GithubDataAccess for stuff like this.