From 32663696277020b807146dfaf091222ee1c74183 Mon Sep 17 00:00:00 2001 From: Billy Date: Tue, 10 May 2016 11:40:46 -0700 Subject: [PATCH 1/4] Create Peer Review - Bill --- Peer Review - Bill | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 Peer Review - Bill diff --git a/Peer Review - Bill b/Peer Review - Bill new file mode 100644 index 0000000..01b7d9d --- /dev/null +++ b/Peer Review - Bill @@ -0,0 +1,36 @@ +1. Does the project appear to meet the technical requirements? Write up one sentence on your findings and give a score 0-3. + +Is your peer making API calls, using SDK's/third-party libraries? +bottom navi is a 3rd party library. + +Is your peer making use of Services? If so, are they offloading long tasks to a separate thread, i.e. AsyncTask, Runnable, IntentService, etc. +N/A at the moment. I see most of the features are not done. + +Is your peer making use of Fragments? If so, are they passing data from Fragment to Activity via interfaces? If not, why did absense of Fragments make sense? +I see Cher is converting to Fragments. Does not see any interfaces at the momenet since it's not done. + +Is your peer making use of RecyclerView? If so, does it appear to be working correctly ( implementation and otherwise )? +I don't see recycleview being use at the moment. + +Is your peer making use of some sort of persistent storage, i.e. Firebase or SQLite? If so, why do you think Firebase/SQLite was chosen? Could they have used one or the other instead and why? +Firebase to store user info. Firebase is good to share pet info throughout the user + +2. Does the project appear to be creative, innovative, and different from any competition? Write up one sentence on your findings and give a score 0-3. + +Is your peer making use of proper UX patterns we learned in class? If not, what are they doing that is unconvetional or that might confuse a user ( you )? +Is your peer making anything cool or awesome that you would like to note or applaud them on? + + +3. Does the project appear to follow correct coding styles and best practices? Write up one sentence on your findings and give a score 0-3. + +Are you able to reasonably follow the code without having anyone answer your questions? +Are you able to make sense of what the code is doing or is trying to do? +4. Find two pieces of code of any size: one that is readable and easy to follow and one that is difficult to follow and understand. + +What makes the readable code readable? Be as detailed as you can in your answer, it can be challenging to explain why something is easy to undertand +What makes the difficult code harder to follow? Be as detailed as you can in your answer. +5. High level project overview: Take a look at as many individual files as you have time for + +Does this class make sense? +Does the structure of the class make sense? +Is it clear what this class is supposed to do? From 1c14017d5d8559c3134e4afbd0d634c9864cf9a7 Mon Sep 17 00:00:00 2001 From: Billy Date: Tue, 10 May 2016 11:57:49 -0700 Subject: [PATCH 2/4] Update Peer Review - Bill --- Peer Review - Bill | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/Peer Review - Bill b/Peer Review - Bill index 01b7d9d..9e5f3f0 100644 --- a/Peer Review - Bill +++ b/Peer Review - Bill @@ -1,4 +1,5 @@ 1. Does the project appear to meet the technical requirements? Write up one sentence on your findings and give a score 0-3. +I can see Cher using 3rd party library and fragments. 2 Is your peer making API calls, using SDK's/third-party libraries? bottom navi is a 3rd party library. @@ -7,7 +8,7 @@ Is your peer making use of Services? If so, are they offloading long tasks to a N/A at the moment. I see most of the features are not done. Is your peer making use of Fragments? If so, are they passing data from Fragment to Activity via interfaces? If not, why did absense of Fragments make sense? -I see Cher is converting to Fragments. Does not see any interfaces at the momenet since it's not done. +I see Cher is converting to Fragments. Does not see any interfaces at the moment since it's not done. Is your peer making use of RecyclerView? If so, does it appear to be working correctly ( implementation and otherwise )? I don't see recycleview being use at the moment. @@ -16,21 +17,38 @@ Is your peer making use of some sort of persistent storage, i.e. Firebase or SQL Firebase to store user info. Firebase is good to share pet info throughout the user 2. Does the project appear to be creative, innovative, and different from any competition? Write up one sentence on your findings and give a score 0-3. + -- first time hearing about a pet sitting app, creative enough - 2 Is your peer making use of proper UX patterns we learned in class? If not, what are they doing that is unconvetional or that might confuse a user ( you )? +-- app are for dog owners + Is your peer making anything cool or awesome that you would like to note or applaud them on? +--getting FB user name and email. connecting to Firebase properly is good 3. Does the project appear to follow correct coding styles and best practices? Write up one sentence on your findings and give a score 0-3. +-- clean code syle - 3 Are you able to reasonably follow the code without having anyone answer your questions? +-- yes, most of the codes have java doc or comments explaining what it does. + Are you able to make sense of what the code is doing or is trying to do? +-- simple to understand + + 4. Find two pieces of code of any size: one that is readable and easy to follow and one that is difficult to follow and understand. What makes the readable code readable? Be as detailed as you can in your answer, it can be challenging to explain why something is easy to undertand +-- setting up user info to firebase. the naming convention is good and able to follow the code to how the user will be created with Firebase. + What makes the difficult code harder to follow? Be as detailed as you can in your answer. +-- the app doesn't have much coding involved. can't follow on how it will work. + 5. High level project overview: Take a look at as many individual files as you have time for Does this class make sense? + -- the classes make sense Does the structure of the class make sense? + -- yes Is it clear what this class is supposed to do? +-- very clear From 585bbbc66a983d67258bb2f7b7f89bd1ba6bc1bd Mon Sep 17 00:00:00 2001 From: Billy Date: Tue, 10 May 2016 12:03:03 -0700 Subject: [PATCH 3/4] Update Peer Review - Bill --- Peer Review - Bill | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Peer Review - Bill b/Peer Review - Bill index 9e5f3f0..426cd43 100644 --- a/Peer Review - Bill +++ b/Peer Review - Bill @@ -1,5 +1,5 @@ 1. Does the project appear to meet the technical requirements? Write up one sentence on your findings and give a score 0-3. -I can see Cher using 3rd party library and fragments. 2 +I can see Cher using 3rd party library and fragments. 1.5 Is your peer making API calls, using SDK's/third-party libraries? bottom navi is a 3rd party library. From f5de4a3e93758eba06b4edabea74948c50a5e5ed Mon Sep 17 00:00:00 2001 From: Billy Date: Tue, 10 May 2016 13:44:48 -0700 Subject: [PATCH 4/4] Update Peer Review - Bill --- Peer Review - Bill | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Peer Review - Bill b/Peer Review - Bill index 426cd43..e71cc3a 100644 --- a/Peer Review - Bill +++ b/Peer Review - Bill @@ -1,5 +1,5 @@ 1. Does the project appear to meet the technical requirements? Write up one sentence on your findings and give a score 0-3. -I can see Cher using 3rd party library and fragments. 1.5 +I can see Cher using firebase, 3rd party library (bottom navi) and fragment. Will give it a 2. Is your peer making API calls, using SDK's/third-party libraries? bottom navi is a 3rd party library. @@ -23,11 +23,11 @@ Is your peer making use of proper UX patterns we learned in class? If not, what -- app are for dog owners Is your peer making anything cool or awesome that you would like to note or applaud them on? ---getting FB user name and email. connecting to Firebase properly is good +--getting FB user name and email. connecting to Firebase properly is good. 3. Does the project appear to follow correct coding styles and best practices? Write up one sentence on your findings and give a score 0-3. --- clean code syle - 3 +-- clean code syle - 2 Are you able to reasonably follow the code without having anyone answer your questions? -- yes, most of the codes have java doc or comments explaining what it does. @@ -42,7 +42,7 @@ What makes the readable code readable? Be as detailed as you can in your answer, -- setting up user info to firebase. the naming convention is good and able to follow the code to how the user will be created with Firebase. What makes the difficult code harder to follow? Be as detailed as you can in your answer. --- the app doesn't have much coding involved. can't follow on how it will work. +-- the app doesn't have much coding done. can't follow on how it will work base on looking from codes alone. 5. High level project overview: Take a look at as many individual files as you have time for