Skip to content

feat: Improve coverage for VNC#311

Draft
fghaas wants to merge 1 commit into
cleura:mainfrom
fghaas:vnc
Draft

feat: Improve coverage for VNC#311
fghaas wants to merge 1 commit into
cleura:mainfrom
fghaas:vnc

Conversation

@fghaas
Copy link
Copy Markdown
Contributor

@fghaas fghaas commented Jun 18, 2025

  • Add a wait_for_vnc() method (analogous to wait_for_rdp()).
  • Adapt the Guacamole client so that it uses 5900 as the default VNC port.
  • Add VNC coverage to tests.

* Add a wait_for_vnc() method (analogous to wait_for_rdp()).
* Adapt the Guacamole client so that it uses 5900 as the default VNC
  port.
* Add VNC coverage to tests.
@fghaas
Copy link
Copy Markdown
Contributor Author

fghaas commented Jun 18, 2025

@mrtmm This is extremely tentative, but does the approach here look reasonable to you?

(I'm debating if this is properly feat or fix — our README does mention VNC so there's some merit in the argument that this is really a fix.)

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.52%. Comparing base (8ed9d35) to head (b870873).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
+ Coverage   95.50%   95.52%   +0.02%     
==========================================
  Files          24       24              
  Lines        1979     1990      +11     
==========================================
+ Hits         1890     1901      +11     
  Misses         89       89              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mrtmm
Copy link
Copy Markdown
Contributor

mrtmm commented Jun 18, 2025

Changes look good to me; I would keep the feat, a fix in my opinion would be updating the README to document the actual feature support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants