feat: Improve coverage for VNC#311
Draft
fghaas wants to merge 1 commit into
Draft
Conversation
* Add a wait_for_vnc() method (analogous to wait_for_rdp()). * Adapt the Guacamole client so that it uses 5900 as the default VNC port. * Add VNC coverage to tests.
Contributor
Author
|
@mrtmm This is extremely tentative, but does the approach here look reasonable to you? (I'm debating if this is properly |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #311 +/- ##
==========================================
+ Coverage 95.50% 95.52% +0.02%
==========================================
Files 24 24
Lines 1979 1990 +11
==========================================
+ Hits 1890 1901 +11
Misses 89 89 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Changes look good to me; I would keep the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wait_for_vnc()method (analogous towait_for_rdp()).