From 73270d3e68c86fa19eae9bdc5ea880ad3e10a40c Mon Sep 17 00:00:00 2001 From: Kris Wong Date: Thu, 9 Jul 2026 10:10:25 -0500 Subject: [PATCH] docs(code-review): correct stale prefix-harness "Phase 4b" comments PLN-1229 delivered the deterministic-prefix golden harness (prefix_golden_harness.py) and its subprocess A/B parity oracle, but two docstrings and the SCHEMA.md golden-fixture section still described that work as a future "Phase 4b" that "will extend" the post-collection harness. Update golden_fixture_harness.py, the cmd_prepare_run docstring, and SCHEMA.md section 12 to point at the delivered harness and note the orchestrator now runs the deterministic prefix in-process via run-prefix rather than walking those stages one at a time. Docs-only; bump 3.4.0 -> 3.4.1. Co-Authored-By: Claude Opus 4.8 --- CHANGELOG.md | 5 +++++ plugins/code-review/.claude-plugin/plugin.json | 2 +- plugins/code-review/SCHEMA.md | 6 ++++-- plugins/code-review/tools/python/code_review_helpers.py | 3 ++- plugins/code-review/tools/python/golden_fixture_harness.py | 7 +++++-- 5 files changed, 17 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 99bb4f7..99c017c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,11 @@ All notable changes to the claude-plugins project will be documented in this fil The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/). Entries are listed newest-first; each plugin section is treated as released when merged to `main`. +### code-review v3.4.1 + +#### Fixed +- Corrected stale documentation that described the deterministic-prefix golden harness as unbuilt future work. The `golden_fixture_harness.py` and `cmd_prepare_run` docstrings and the `SCHEMA.md` golden-fixture section now point at the delivered prefix harness (`prefix_golden_harness.py`) and its subprocess A/B parity oracle, and note that the orchestrator runs the deterministic prefix in-process via `run-prefix` rather than walking those stages one at a time. + ### code-review v3.4.0 #### Changed diff --git a/plugins/code-review/.claude-plugin/plugin.json b/plugins/code-review/.claude-plugin/plugin.json index 682da0a..9422b0e 100644 --- a/plugins/code-review/.claude-plugin/plugin.json +++ b/plugins/code-review/.claude-plugin/plugin.json @@ -1,7 +1,7 @@ { "name": "code-review", "description": "Code review plugin", - "version": "3.4.0", + "version": "3.4.1", "author": { "name": "ClosedLoop", "email": "support@closedloop.ai" diff --git a/plugins/code-review/SCHEMA.md b/plugins/code-review/SCHEMA.md index 13d0cfb..f41fc34 100644 --- a/plugins/code-review/SCHEMA.md +++ b/plugins/code-review/SCHEMA.md @@ -719,8 +719,10 @@ The remaining 3 fixtures requiring plans 03/05/06 (`golden_impact_with_callsites`, `golden_coverage_gap`, `golden_budget_exceeded`) have reserved directories with READMEs and are skipped via a `_DEFERRED_FIXTURES` map in the test module until -their dependent plans land. Phase 4b will extend the harness to walk -`run_plan.json` end-to-end through a declarative stage runner. +their dependent plans land. The deterministic prefix (stages `01` through +Gate B) is pinned separately by `prefix_golden_harness.py` (PLN-1229 +Phase 0); its subprocess A/B parity oracle guards the in-process +`run-prefix` batch runner byte-for-byte. --- diff --git a/plugins/code-review/tools/python/code_review_helpers.py b/plugins/code-review/tools/python/code_review_helpers.py index b8a34f3..47bdba6 100644 --- a/plugins/code-review/tools/python/code_review_helpers.py +++ b/plugins/code-review/tools/python/code_review_helpers.py @@ -11013,7 +11013,8 @@ def cmd_prepare_run(args: argparse.Namespace) -> int: """Emit ``run_plan.json`` describing the full review pipeline. PLN-719 Section 6. The output is consumed by the ``/start`` orchestrator, - which walks the plan stage-by-stage (Phase 4b). + which runs the deterministic prefix in-process via ``run-prefix`` + (PLN-1229) and walks the reviewer tail stage-by-stage. Determinism: same inputs produce byte-identical output **except for the ``review_id`` field**, which is a fresh ``uuid.uuid4()`` per invocation. diff --git a/plugins/code-review/tools/python/golden_fixture_harness.py b/plugins/code-review/tools/python/golden_fixture_harness.py index c30e306..b96092d 100644 --- a/plugins/code-review/tools/python/golden_fixture_harness.py +++ b/plugins/code-review/tools/python/golden_fixture_harness.py @@ -17,8 +17,11 @@ the wall-clock telemetry block) are normalized before diff/write so the expected files stay stable across runs. -Phase 8 ships the post-collection harness only. Phase 4b will extend it to -walk ``run_plan.json`` end-to-end through a declarative stage runner. +This module pins the post-collection half only (``collect-findings`` → +``validate`` → ``finalize-result``). The deterministic prefix — stages ``01`` +through Gate B — is pinned separately by ``prefix_golden_harness.py`` +(PLN-1229 Phase 0), whose subprocess A/B parity oracle guards the in-process +``run-prefix`` batch runner byte-for-byte. """ from __future__ import annotations