refactor: remove previously deprecated list of errors features

Author: lindyhopchris

CHANGELOG.md

@@ -3,6 +3,13 @@
 All notable changes to this project will be documented in this file. This project adheres to
 [Semantic Versioning](http://semver.org/) and [this changelog format](http://keepachangelog.com/).
 
+## Next Major
+
+### Removed
+
+- Removed the deprecated `contains()` method from the `ListOfErrors` interface. Use `any()` instead.
+- The `first()` method on the `ListOfErrors` interface no longer accepts arguments. Use `find()` instead.
+
 ## Unreleased
 
 ## [5.1.0] - 2026-01-01

phpunit.xml

@@ -11,7 +11,7 @@
          cacheDirectory=".phpunit.cache"
          backupStaticProperties="false"
          failOnWarning="true"
-         failOnDeprecation="false"
+         failOnDeprecation="true"
          failOnNotice="true"
 >
     <coverage/>

src/Contracts/Toolkit/Result/ListOfErrors.php

@@ -23,10 +23,8 @@ interface ListOfErrors extends ListIterator
 {
     /**
      * Get the first error in the list, or the first matching error.
-     *
-     * @param (Closure(Error): bool)|UnitEnum|null $matcher
      */
-    public function first(Closure|UnitEnum|null $matcher = null): ?Error;
+    public function first(): ?Error;
 
     /**
      * Find the first matching error in the list.
@@ -42,14 +40,6 @@ public function find(Closure|UnitEnum $matcher): ?Error;
      */
     public function sole(Closure|UnitEnum|null $matcher = null): Error;
 
-    /**
-     * Does the list contain a matching error?
-     *
-     * @param (Closure(Error): bool)|UnitEnum $matcher
-     * @deprecated 6.0 use any() instead.
-     */
-    public function contains(Closure|UnitEnum $matcher): bool;
-
     /**
      * Does the list contain at least one matching error?
      *

src/Toolkit/Result/ListOfErrors.php

@@ -16,7 +16,6 @@
 use CloudCreativity\Modules\Contracts\Toolkit\Result\Error as IError;
 use CloudCreativity\Modules\Contracts\Toolkit\Result\ListOfErrors as IListOfErrors;
 use CloudCreativity\Modules\Toolkit\Iterables\IsList;
-use Deprecated;
 use LogicException;
 use UnitEnum;
 
@@ -46,18 +45,9 @@ public function __construct(IError ...$errors)
         $this->stack = array_values($errors);
     }
 
-    public function first(Closure|UnitEnum|null $matcher = null): ?IError
+    public function first(): ?IError
     {
-        if ($matcher === null) {
-            return $this->stack[0] ?? null;
-        }
-
-        trigger_error(
-            'Calling first() with a matcher is deprecated and will be removed in 6.0; use find() instead.',
-            E_USER_DEPRECATED,
-        );
-
-        return $this->find($matcher);
+        return $this->stack[0] ?? null;
     }
 
     public function find(Closure|UnitEnum $matcher): ?IError
@@ -85,12 +75,6 @@ public function sole(Closure|UnitEnum|null $matcher = null): IError
         ));
     }
 
-    #[Deprecated(message: 'use any() instead', since: '5.0.0-rc.2')]
-    public function contains(Closure|UnitEnum $matcher): bool
-    {
-        return $this->any($matcher);
-    }
-
     public function any(Closure|UnitEnum $matcher): bool
     {
         return array_any($this->stack, $this->where($matcher));

tests/Unit/Toolkit/Result/ListOfErrorsTest.php

@@ -96,22 +96,6 @@ public function testFirst(): void
         $this->assertSame($a, $errors->first());
     }
 
-    public function testFirstWithMatcher(): void
-    {
-        $errors = new ListOfErrors(
-            new Error(null, 'Message A'),
-            new Error(null, 'Message B'),
-            $c = new Error(null, 'Message C'),
-            new Error(null, 'Message D'),
-            $e = new Error(code: TestUnitEnum::Bat),
-        );
-
-        $this->assertSame($c, $errors->first(fn (IError $error) => 'Message C' === $error->message()));
-        $this->assertSame($e, $errors->first(TestUnitEnum::Bat));
-        $this->assertNull($errors->first(fn (IError $error) => 'Message E' === $error->message()));
-        $this->assertNull($errors->first(TestUnitEnum::Baz));
-    }
-
     public function testFind(): void
     {
         $errors = new ListOfErrors(
@@ -128,21 +112,6 @@ public function testFind(): void
         $this->assertNull($errors->find(TestUnitEnum::Baz));
     }
 
-    public function testContains(): void
-    {
-        $errors = new ListOfErrors(
-            new Error(message: 'Message A'),
-            new Error(message: 'Message B'),
-            new Error(message: 'Message C'),
-            new Error(code: TestUnitEnum::Baz, message: 'Message D'),
-        );
-
-        $this->assertTrue($errors->contains(fn (IError $error) => 'Message C' === $error->message()));
-        $this->assertTrue($errors->contains(TestUnitEnum::Baz));
-        $this->assertFalse($errors->contains(fn (IError $error) => 'Message E' === $error->message()));
-        $this->assertFalse($errors->contains(TestUnitEnum::Bat));
-    }
-
     public function testAny(): void
     {
         $errors = new ListOfErrors(