Skip to content

Commit 8b8b8e9

Browse files
committed
tests: add some minor improvements to log decorator tests
1 parent 9df6335 commit 8b8b8e9

2 files changed

Lines changed: 15 additions & 8 deletions

File tree

tests/Unit/Toolkit/Loggable/ObjectDecoratorTest.php

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
namespace CloudCreativity\Modules\Tests\Unit\Toolkit\Loggable;
1414

15+
use CloudCreativity\Modules\Contracts\Toolkit\Loggable\ContextProvider;
1516
use CloudCreativity\Modules\Contracts\Toolkit\Messages\Message;
1617
use CloudCreativity\Modules\Toolkit\Loggable\ObjectDecorator;
1718
use CloudCreativity\Modules\Toolkit\Loggable\Sensitive;
@@ -61,11 +62,13 @@ public function testItUsesObjectProperties(): void
6162
'blah' => null,
6263
];
6364

64-
$iterator = new ObjectDecorator($source);
65+
$decorator = new ObjectDecorator($source);
6566

66-
$this->assertSame(array_keys($expected), $iterator->keys());
67-
$this->assertSame($expected, iterator_to_array($iterator));
68-
$this->assertSame($expected, $iterator->all());
67+
$this->assertInstanceOf(ContextProvider::class, $decorator);
68+
$this->assertSame(array_keys($expected), $decorator->keys());
69+
$this->assertSame($expected, iterator_to_array($decorator));
70+
$this->assertSame($expected, $decorator->all());
71+
$this->assertSame($expected, $decorator->context());
6972
$this->assertSame($expected, $this->factory->make($source));
7073
}
7174

@@ -93,10 +96,11 @@ public function __construct(
9396
'blah2' => 'World',
9497
];
9598

96-
$iterator = new ObjectDecorator($source);
99+
$decorator = new ObjectDecorator($source);
97100

98-
$this->assertSame(array_keys($expected), $iterator->keys());
99-
$this->assertSame($expected, $iterator->all());
101+
$this->assertSame(array_keys($expected), $decorator->keys());
102+
$this->assertSame($expected, $decorator->all());
103+
$this->assertSame($expected, $decorator->context());
100104
$this->assertSame($expected, $this->factory->make($source));
101105
}
102106
}

tests/Unit/Toolkit/Loggable/ResultDecoratorTest.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,10 @@ public function testSuccess(): void
7070
'success' => true,
7171
];
7272

73-
$this->assertSame($expected, (new ResultDecorator($result))->context());
73+
$decorator = new ResultDecorator($result);
74+
75+
$this->assertInstanceOf(ContextProvider::class, $decorator);
76+
$this->assertSame($expected, $decorator->context());
7477
$this->assertSame($expected, $this->factory->make($result));
7578
}
7679

0 commit comments

Comments
 (0)