From d2b969f8f78c25e52590fbd09c69beccdb21b30d Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 12 Feb 2026 11:03:49 +0000 Subject: [PATCH 1/2] build(deps-dev): bump rubocop from 1.84.1 to 1.84.2 Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.84.1 to 1.84.2. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop/compare/v1.84.1...v1.84.2) --- updated-dependencies: - dependency-name: rubocop dependency-version: 1.84.2 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- Gemfile | 2 +- Gemfile.lock | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Gemfile b/Gemfile index 5c055a84d7..c06b6e3908 100644 --- a/Gemfile +++ b/Gemfile @@ -79,7 +79,7 @@ group :test do gem 'rspec-its' gem 'rspec-rails', '~> 8.0.2' gem 'rspec-wait' - gem 'rubocop', '~> 1.84.1' + gem 'rubocop', '~> 1.84.2' gem 'rubocop-capybara' gem 'rubocop-factory_bot' gem 'rubocop-rails', '~> 2.34' diff --git a/Gemfile.lock b/Gemfile.lock index 342d678600..17d56bf302 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -476,7 +476,7 @@ GEM activesupport (>= 3.0.0) mustache (~> 1.0, >= 0.99.4) rspec (~> 3.0) - rubocop (1.84.1) + rubocop (1.84.2) json (~> 2.3) language_server-protocol (~> 3.17.0.2) lint_roller (~> 1.1.0) @@ -680,7 +680,7 @@ DEPENDENCIES rspec-rails (~> 8.0.2) rspec-wait rspec_api_documentation (>= 6.1.0) - rubocop (~> 1.84.1) + rubocop (~> 1.84.2) rubocop-capybara rubocop-factory_bot rubocop-rails (~> 2.34) From e6823eb59ff2ba12d206ccc227d1d3137164cbd8 Mon Sep 17 00:00:00 2001 From: johha Date: Wed, 18 Feb 2026 14:02:53 +0100 Subject: [PATCH 2/2] fix rubocop issues --- spec/request_spec_shared_examples.rb | 12 ++++++------ .../v3/space_manifests_controller_spec.rb | 12 ++++++------ .../diego/cnb/staging_completion_handler_spec.rb | 6 +++--- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/spec/request_spec_shared_examples.rb b/spec/request_spec_shared_examples.rb index 95f817491d..7281736e92 100644 --- a/spec/request_spec_shared_examples.rb +++ b/spec/request_spec_shared_examples.rb @@ -18,15 +18,15 @@ ALL_PERMISSIONS = (LOCAL_ROLES + GLOBAL_SCOPES).freeze CF_NOT_AUTHORIZED = [ - detail: 'You are not authorized to perform the requested action', - title: 'CF-NotAuthorized', - code: 10_003 + { detail: 'You are not authorized to perform the requested action', + title: 'CF-NotAuthorized', + code: 10_003 } ].freeze CF_ORG_SUSPENDED = [ - detail: 'The organization is suspended', - title: 'CF-OrgSuspended', - code: 10_017 + { detail: 'The organization is suspended', + title: 'CF-OrgSuspended', + code: 10_017 } ].freeze RSpec.shared_examples 'paginated response' do |endpoint| diff --git a/spec/unit/controllers/v3/space_manifests_controller_spec.rb b/spec/unit/controllers/v3/space_manifests_controller_spec.rb index a974092497..d496457271 100644 --- a/spec/unit/controllers/v3/space_manifests_controller_spec.rb +++ b/spec/unit/controllers/v3/space_manifests_controller_spec.rb @@ -261,9 +261,9 @@ def error_message(detail) errors = parsed_body['errors'] expect(errors.size).to eq(1) expected_error = [ - 'detail' => "For application 'blah': Buildpack cannot be configured for a docker lifecycle app.", - 'title' => 'CF-UnprocessableEntity', - 'code' => 10_008 + { 'detail' => "For application 'blah': Buildpack cannot be configured for a docker lifecycle app.", + 'title' => 'CF-UnprocessableEntity', + 'code' => 10_008 } ] expect(errors.map { |h| h.except('test_mode_info') }).to match_array(expected_error) end @@ -305,9 +305,9 @@ def error_message(detail) errors = parsed_body['errors'] expect(errors.size).to eq(1) expected_error = [ - 'detail' => "For application 'blah': Buildpacks cannot be configured for a docker lifecycle app.", - 'title' => 'CF-UnprocessableEntity', - 'code' => 10_008 + { 'detail' => "For application 'blah': Buildpacks cannot be configured for a docker lifecycle app.", + 'title' => 'CF-UnprocessableEntity', + 'code' => 10_008 } ] expect(errors.map { |h| h.except('test_mode_info') }).to match_array(expected_error) end diff --git a/spec/unit/lib/cloud_controller/diego/cnb/staging_completion_handler_spec.rb b/spec/unit/lib/cloud_controller/diego/cnb/staging_completion_handler_spec.rb index f0196e314d..68c86f3b47 100644 --- a/spec/unit/lib/cloud_controller/diego/cnb/staging_completion_handler_spec.rb +++ b/spec/unit/lib/cloud_controller/diego/cnb/staging_completion_handler_spec.rb @@ -13,9 +13,9 @@ module CNB lifecycle_type: 'cnb', lifecycle_metadata: { buildpacks: [ - key: 'foo', - name: 'nodejs', - version: '1.0.0' + { key: 'foo', + name: 'nodejs', + version: '1.0.0' } ] }, process_types: {