[Bug]: Removing Service Broker leaves its CFServiceOfferings and CFServicePlans objects

[ybykov-a9s]

What happened?

As a Korifi user
I removed a Service broker and created a new one with the same Service Offerings and Service plans. cf marketplace shows only one set of service offerings of a newly created broker. If I try to create a managed Service instance, I get an error message

Service offering 'postgresql15' is provided by multiple service brokers. Specify a broker name by using the '-b' flag

Inspecting k8s objects using following commands

kubectl -n cf get CFServiceOfferings,CFServicePlans

shows that the newly created Offerings and Plans exist alongside with Offering and Plans of already removed Service Broker.

What you expected to happen

Service offerings and Service plans of the removed Service broker are completely removed from Korifi's configuration.

Acceptance Criteria

GIVEN After removing a Service broker
WHEN I check either cf marketplace command or CFServiceOfferings and CFServicePlans k8s objects
THEN I do not see any leftovers of already removed Service Broker and its Service catalog

How to reproduce it (as minimally and precisely as possible)

1. Create a service broker
2. get its GUID
3. Remove the service broker
4. Make sure that CFServiceOfferings and CFServicePlans linked to the GUID of the removed ServiceBroker broker still exist in the cf namespace

Anything else we need to know?

No response

Environment

Revision of codebase: v0.17.0
Kubernetes version v1.35.0
Cloud provider or hardware configuration: AWS
Others:

[danail-branekov]

When implementing service brokers deletion we intentionally did not implement automatic cleanup of offerings and plans because we were not sure how to handle existing service instances for the broker offerings.

According to the documentation, when deleting a broker, its service instances should be orphaned. We were not sure what that means - should the service instances be still usable, or they should fail. In any case, we should ideally mimic the CF on VMs behaviour.

Could you research what that behaviour should be?

Implementation-wise, we could leverage k8s owner references where CFServiceOfferings and CFServicePlans are owned by the CFServiceBroker object. That ownership could be set by the broker controller when it creates offerings and plans according to the broker catalog. Then, when a CFServiceBroker is deleted, offerings and plans would be garbage collected by k8s. I cannot predict what would be the effect of doing that with the current implementation though - I would assume that all related service instances would become failed. Maybe we would need some additional code to handle this situation in service instance/binding controllers to achieve the CF on VMs behaviour.