Raise PHPStan to level 1 and fix all findings

Bump the analysis level from 0 to 1 and resolve every new finding in code
rather than baselining, matching the level-0 approach.

Real bugs fixed:
- extract_cname() checked an undefined $test['query'] instead of the
  $parsed_url['query'] parameter, so the query-string CNAME branch never ran.
- connection-string.php passed two args to wp_kses_post() (1 arg) and the
  string was not translated; use esc_html__() with a translators comment.
- remove_filter() in class-video.php was called with 4 args (max 3); drop the
  stray accepted_args value.

Defensive / dead code simplified:
- upgrade_connection() initialised $data and now bails when no cloudinary_url
  is present, instead of accessing a possibly-undefined variable.
- Api::upload() initialises $result before the chunk loop so an empty file
  returns a WP_Error rather than reading an undefined variable.
- Removed always-falsy $errors guard in Admin::save_settings().
- Removed redundant empty()/elseif branches in Delivery and Upgrade.

Static-analysis support:
- url_hash added to the Relationship @Property list (valid magic property
  backed by a DB column).
- State and REST_API constructors now use the injected $plugin instead of
  get_plugin_instance()/discarding it, removing unused-parameter warnings.
- New tests/phpstan/stubs/constants.php declares runtime-defined constants
  (CLDN_*, CLOUDINARY_ENDPOINTS_*, CLOUDINARY_CONNECTION_STRING) and the WP
  core constants WPINC/LOGGED_IN_COOKIE that the stub package omits.
- Exclude php/templates/* since view files are included into a class scope,
  so $this is bound at runtime in a way PHPStan cannot model standalone.

Run with: composer phpstan

Author: PatelUtkarsh

php/class-admin.php

@@ -433,7 +433,6 @@ public function init_setting_save() {
 	 */
 	protected function save_settings( $submission, $data ) {
 		$page    = $this->settings->get_setting( $submission );
-		$errors  = array();
 		$pending = false;
 		foreach ( $data as $key => $value ) {
 			$slug    = $submission . $page->separator . $key;
@@ -451,7 +450,7 @@ protected function save_settings( $submission, $data ) {
 			$pending = true;
 		}
 
-		if ( empty( $errors ) && true === $pending ) {
+		if ( true === $pending ) {
 			$results = $this->settings->save();
 			if ( ! empty( $results ) ) {
 				$this->add_admin_notice( 'error_notice', __( 'Settings updated successfully', 'cloudinary' ), 'success' );

php/class-connect.php

@@ -564,7 +564,7 @@ public function test_ping() {
 	protected function extract_cname( $parsed_url ) {
 		$cname = null;
 
-		if ( ! empty( $test['query'] ) ) {
+		if ( ! empty( $parsed_url['query'] ) ) {
 			$config_params = array();
 			wp_parse_str( $parsed_url['query'], $config_params );
 			$cname = isset( $config_params['cname'] ) ? $config_params['cname'] : $cname;
@@ -874,6 +874,7 @@ public function get_notices() {
 	 */
 	public function upgrade_connection( $old_version ) {
 
+		$data = array();
 		if ( version_compare( $old_version, '2.0.0', '>' ) ) {
 			// Post V1 - quick check all details are valid.
 			$data = $this->settings->get_value( 'connect' );
@@ -904,6 +905,9 @@ public function upgrade_connection( $old_version ) {
 		}
 
 		// Test upgraded details.
+		if ( empty( $data['cloudinary_url'] ) ) {
+			return; // Nothing to upgrade.
+		}
 		$data['cloudinary_url'] = str_replace( 'CLOUDINARY_URL=', '', $data['cloudinary_url'] );
 		$test                   = $this->test_connection( $data['cloudinary_url'] );
 

php/class-delivery.php

@@ -1744,7 +1744,7 @@ protected function is_content_dir( $url ) {
 			$dirname = trim( substr( $path, strlen( $base ), 8 ), DIRECTORY_SEPARATOR );
 			if ( empty( $dirname ) || preg_match( '/\d{4}\/\d{2}/', $dirname ) ) {
 				$is_local = true;
-			} elseif ( ! empty( $dirname ) ) {
+			} else {
 				$is_local = false;
 			}
 		}

php/class-rest-api.php

@@ -26,6 +26,13 @@ class REST_API {
 	 */
 	public $endpoints;
 
+	/**
+	 * Holds the plugin instance.
+	 *
+	 * @var Plugin
+	 */
+	protected $plugin;
+
 	/**
 	 * The nonce key used for WordPress REST API authentication.
 	 *
@@ -38,7 +45,8 @@ class REST_API {
 	 *
 	 * @param Plugin $plugin Instance of the global Plugin.
 	 */
-	public function __construct( Plugin $plugin ) { // phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter.Found
+	public function __construct( Plugin $plugin ) {
+		$this->plugin = $plugin;
 		add_action( 'rest_api_init', array( $this, 'rest_api_init' ), PHP_INT_MAX );
 	}
 

php/connect/class-api.php

@@ -439,6 +439,7 @@ public function upload_large( $attachment_id, $args ) {
 		$chunk_size     = 20000000;
 		$index          = 0;
 		$file_size      = filesize( $args['file'] );
+		$result         = new \WP_Error( 'upload_error', __( 'No data to upload.', 'cloudinary' ) );
 		while ( ! feof( $src ) ) {
 			$current_loc = $index * $chunk_size;
 			if ( $current_loc >= $file_size ) {

php/media/class-upgrade.php

@@ -248,7 +248,7 @@ public function migrate_legacy_meta( $attachment_id ) {
 		update_post_meta( $attachment_id, '_wp_attachment_metadata', $old_meta );
 
 		// migrate from pre v2 meta.
-		if ( empty( $v2_meta ) && empty( $v3_meta ) ) {
+		if ( empty( $v2_meta ) ) {
 			// Attempt old post meta.
 			$public_id = get_post_meta( $attachment_id, Sync::META_KEYS['public_id'], true );
 			if ( ! empty( $public_id ) ) {

php/media/class-video.php

@@ -221,7 +221,7 @@ public function admin_enqueue_scripts() {
 	 */
 	public function filter_video_block_render_block( $block_content, array $block ) {
 		if ( 'core/video' === $block['blockName'] ) {
-			remove_filter( 'render_block', array( $this, 'filter_video_block_render_block' ), 10, 2 );
+			remove_filter( 'render_block', array( $this, 'filter_video_block_render_block' ), 10 );
 
 			$filtered_block = $this->filter_video_block_pre_render( $block, $block );
 			$block_content  = render_block( $filtered_block );

php/relate/class-relationship.php

@@ -22,6 +22,7 @@
  * @property string|null $text_overlay
  * @property string|null $image_overlay
  * @property string|null $sized_url
+ * @property string|null $url_hash
  * @property string|null $media_context
  */
 class Relationship {

php/templates/connection-string.php

@@ -14,7 +14,8 @@
 		<p>
 			<?php
 			printf(
-				wp_kses_post( 'After creating your %s:', 'cloudinary' ),
+				// translators: %s is the "Cloudinary account" link.
+				esc_html__( 'After creating your %s:', 'cloudinary' ),
 				sprintf(
 				// translators: Link to create a Cloudinary account.
 					esc_html__( '%1$sCloudinary account%2$s', 'cloudinary' ),

php/ui/class-state.php

@@ -61,8 +61,8 @@ class State {
 	 *
 	 * @param Plugin $plugin Instance of the plugin.
 	 */
-	public function __construct( Plugin $plugin ) { // phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter.Found
-		$this->plugin  = get_plugin_instance();
+	public function __construct( Plugin $plugin ) {
+		$this->plugin  = $plugin;
 		$this->user_id = get_current_user_id();
 
 		if ( ! empty( $this->user_id ) ) {